Add file-utils feature into remote() function#417
Add file-utils feature into remote() function#417jdespatis wants to merge 3 commits intoyeoman:masterfrom jdespatis:file-utils-for-remote
Conversation
|
Hi there, thanks for the PR. Could you add unit test? |
|
@SBoudrias I was fearing the question.. |
|
@passy is going to try authoring the tests for this. Initially assigning the issue to him. |
|
@addyosmani @passy ok thanks ! For memory, the unit tests added by @SBoudrias for So Inspiration has to be taken there in order to do the same thing for |
|
@passy ping, since you're assigned to this ;) |
Add tests for remote.{src,dest}
|
I'm not super convinced by the unit tests added. I think it'd be more relevant to test that the bases path are setup correctly on the env. E.g.: (Also, it'd be better to send PR without merge commit included) |
|
@SBoudrias I can try a You prefer to fork this PR to add your corrections @SBoudrias ? or you can make your own PR and I close this one, no problem also |
|
I'm taking care of it ATM. |
|
ok thanks @SBoudrias ! |
|
@SBoudrias Thanks! |
|
Merged on master, thanks a lot! |
|
cool ;) thanks |
|
Great to see this land. Thanks! |
Push #378 further, in order to also implement
file-utilslogic intoremote()function