Fix windows not working with wait read socket stm#1077
Merged
Conversation
Vlix
force-pushed
the
fix-windows-not-working-with-waitReadSocketSTM
branch
from
0857272 to
998a83b
Compare
…sn't actually different in code, except that it hopefully works on Windows again
Vlix
force-pushed
the
fix-windows-not-working-with-waitReadSocketSTM
branch
from
998a83b to
16c1541
Compare
Contributor
|
Looks a nice idea to me. |
Vlix
commented
May 27, 2026
| makeGracefulRecv sock pool ss appsInProgress = do | ||
| sockWait <- waitReadSocketSTM sock | ||
| sockWait <- | ||
| #if !WINDOWS |
Contributor
Author
There was a problem hiding this comment.
Shall I change this to the following?
#if !WINDOWS && MIN_VERSION_network(3,2,2)
Contributor
Author
There was a problem hiding this comment.
@kazu-yamamoto Added in new commits, and I checked that without it it indeed fails to build with network-3.2.1.0.
LTS-20/21 in CI will check that it works with network < 3.2.2
EDIT: Whoops, warp-quic won't build with network-3.2.1.0... so we'll have to leave it as is in the CI. But I did check and warp itself builds with network < 3.2.2 now.
Vlix
force-pushed
the
fix-windows-not-working-with-waitReadSocketSTM
branch
from
05e9e49 to
7c14d47
Compare
3 tasks
kazu-yamamoto
approved these changes
May 28, 2026
Contributor
kazu-yamamoto
left a comment
kazu-yamamoto
left a comment
There was a problem hiding this comment.
LGTM.
@Vlix Please merge this PR by yourself and release a new version if you wish.
Contributor
Author
|
Published new patch version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
After submitting your PR:
Patch to hopefully build with Windows again. Fixing #1073
@sheaf: could you test Windows functionality with this code?