feat: integrate batcher with payment system#519
Merged
MauroToscano merged 71 commits intomainfrom Jun 28, 2024
Merged
Conversation
…m' into 412-feat-implement-payment-system
…m' into 412-feat-implement-payment-system
…m' into 412-feat-implement-payment-system
…ng it consumes more gas than it refunds
…payment-system' into 460-feat-implement-user-batcher-payment-system
taturosati
reviewed
Jun 28, 2024
Merged
Contributor
Co-authored-by: Tatu <65305492+srosati@users.noreply.github.com>
MauroToscano
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Integrates batcher with the new batcher payment service.
When a user sends a proof, the message is signed and the batcher verifies the signature and recovers the user address. Then, it checks that the address has funds in the batcher payment service.
Testing:
For fine grained testing:
This will start the batcher without sending funds.
An error will be logged meaning that the user has no funds in the batcher payment system.
Happy path:
make batcher_startis called, a transaction is made from the user to the payment system to add funds in devnet.