spec: shiroa fixes#533
Conversation
- Strip raw blocks from chapter titles for `project` argument - Add an explicit description (based on chapter title) to chapters to avoid compilation issues when context appears early in the chapter - Export interaction counts from the pdf version to use in shiroa, since otherwise we run into convergence issues that are hard to debug
Codex Code ReviewFindings:
No security issues stood out in this diff. I couldn’t run the Typst/Shiroa build locally because |
Review: spec/shiroa-fixesThis PR fixes three concrete shiroa build problems (raw in titles, missing chapter descriptions, interaction-count convergence). No security issues; no VM/crypto logic touched. Two minor notes left as inline comments:
Everything else looks good:
|
| typst query ebook.typ '<interaction_count>' --field value > interaction_count.json | ||
|
|
||
| # And build | ||
| shiroa build |
There was a problem hiding this comment.
Just as a safety precaution
| shiroa build | |
| RAYON_NUM_THREADS=1 shiroa build |
Also, this stuff still freezes my PC due to RAM usage :(
There was a problem hiding this comment.
idk if that should be a default in the build script, vs being set in your local env. It would also make the builds slower when the memory is not a restriction.
I could add a build_shiroa_slow.sh that adds the flag?
There was a problem hiding this comment.
Perhaps a better solution would be to allow the number of threads to be passed as a parameter/have a flag to enable multi-threading, where in the script it is documented that this might be a tricky thing to do. And then print a message at start such as
Starting shiroa build on X threads...
when executing to indicate what is happening & suggest to people new to the script that they can multi-thread the process.
Given that (even with THREADS=1) this program often crashes my PC (which has a not unreasonably low 16GB of RAM), I think that we should be cautious to enable multi-threading by default.
Co-authored-by: Erik <159244975+erik-3milabs@users.noreply.github.com>
projectargument