CoreHandler is no longer a parent class to all the other Handlers#2
Merged
CoreHandler is no longer a parent class to all the other Handlers#2
Conversation
yetnt
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update introduces a significant structural change: CoreHandler is no longer a parent class to the other handlers. Instead of extending CoreHandler, all handlers now take it as a property, passed explicitly as the first parameter in their constructors. This design improves modularity. To support this, the ReadyHandler constructor has also changed; the shard client must now be provided as the second parameter, after CoreHandler. If no shard client is being used, undefined must be passed explicitly. These changes enable each shard to work independently while maintaining clear communication between handlers through the CoreHandler instance. However, the update introduces breaking changes, as existing code must now be adjusted to account for the new constructor requirements.