Skip to content

deps(tokio): bump minor ver; extract workspace dep; tree-shake features#3903

Merged
Madoshakalaka merged 2 commits intomasterfrom
bump-tokio-minor
Aug 21, 2025
Merged

deps(tokio): bump minor ver; extract workspace dep; tree-shake features#3903
Madoshakalaka merged 2 commits intomasterfrom
bump-tokio-minor

Conversation

@Madoshakalaka
Copy link
Member

  1. removed all the features = ["full"] and replaced with minimum feature sets, this should help with binary sizes and compile time
  2. bumped tokios minor version of tokio. No useful inclusions after surveying new feature additions. A regression regarding Instant was fixed for wasm32-unknown-unknown but we were on a lower version that didn't have the bug to begin with.
  3. Extracted tokio as a workspace dependency. Cargo didn't have the workspace dependency feature when Yew started and it's about time.

@github-actions
Copy link

github-actions bot commented Aug 19, 2025

Visit the preview URL for this PR (updated for commit c59ebd8):

https://yew-rs-api--pr3903-bump-tokio-minor-obi3rve2.web.app

(expires Wed, 27 Aug 2025 12:04:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Aug 19, 2025

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.484 ns      │ 2.549 ns      │ 2.487 ns      │ 2.489 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.462 ns      │ 3.779 ns      │ 2.466 ns      │ 2.529 ns      │ 100     │ 1000000000

@github-actions
Copy link

github-actions bot commented Aug 19, 2025

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.001 293.447 291.461 0.773
Hello World 10 471.853 485.887 475.601 4.213
Function Router 10 1622.379 1682.379 1640.934 16.918
Concurrent Task 10 1005.586 1007.600 1006.607 0.701
Many Providers 10 1091.819 1152.604 1115.422 23.241

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 290.866 292.434 291.272 0.554
Hello World 10 523.436 527.801 525.946 1.395
Function Router 10 1597.633 1614.793 1602.635 5.297
Concurrent Task 10 1004.905 1006.965 1006.071 0.540
Many Providers 10 1077.339 1129.075 1100.531 14.076

@github-actions
Copy link

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 99.188 99.195 +0.007 +0.007%
boids 167.999 168.005 +0.006 +0.003%
communication_child_to_parent 91.551 91.554 +0.003 +0.003%
communication_grandchild_with_grandparent 102.578 102.578 0 0.000%
communication_grandparent_to_grandchild 97.574 97.573 -0.001 -0.001%
communication_parent_to_child 87.469 87.470 +0.001 +0.001%
contexts 103.683 103.686 +0.003 +0.003%
counter 84.274 84.274 0 0.000%
counter_functional 84.623 84.623 0 0.000%
dyn_create_destroy_apps 87.301 87.274 -0.026 -0.030%
file_upload 98.170 98.170 0 0.000%
function_memory_game 170.058 170.059 +0.001 +0.001%
function_router 337.326 336.237 -1.089 -0.323%
function_todomvc 162.446 162.450 +0.004 +0.002%
futures 236.567 236.567 0 0.000%
game_of_life 104.527 104.512 -0.016 -0.015%
immutable 193.298 193.274 -0.023 -0.012%
inner_html 79.920 79.920 0 0.000%
js_callback 107.405 107.411 +0.006 +0.005%
keyed_list 195.415 195.425 +0.010 +0.005%
mount_point 83.286 83.287 +0.001 +0.001%
nested_list 112.411 112.415 +0.004 +0.003%
node_refs 90.651 90.649 -0.002 -0.002%
password_strength 1782.876 1782.874 -0.002 -0.000%
portals 92.436 92.442 +0.007 +0.007%
router 306.712 305.597 -1.115 -0.364%
suspense 111.410 111.410 0 0.000%
timer 88.550 88.542 -0.008 -0.009%
timer_functional 94.586 94.578 -0.008 -0.008%
todomvc 142.697 142.697 0 0.000%
two_apps 85.640 85.640 0 0.000%
web_worker_fib 134.121 134.121 0 0.000%
web_worker_prime 184.411 184.396 -0.016 -0.008%
webgl 82.888 82.856 -0.031 -0.038%

✅ None of the examples has changed their size significantly.

@Madoshakalaka Madoshakalaka marked this pull request as ready for review August 21, 2025 05:10
@Madoshakalaka Madoshakalaka merged commit 0f05f02 into master Aug 21, 2025
26 of 29 checks passed
@WorldSEnder WorldSEnder deleted the bump-tokio-minor branch October 22, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant