Skip to content

fix custom hook compile failure in edition 2024#3992

Merged
Madoshakalaka merged 1 commit intomasterfrom
fix/hook-rust-2024-lifetime-capture
Feb 19, 2026
Merged

fix custom hook compile failure in edition 2024#3992
Madoshakalaka merged 1 commit intomasterfrom
fix/hook-rust-2024-lifetime-capture

Conversation

@Madoshakalaka
Copy link
Member

Fixes #3774

Tested the fix and it works both with edition 2021 and 2024

@Madoshakalaka Madoshakalaka force-pushed the fix/hook-rust-2024-lifetime-capture branch from 69415c3 to c125681 Compare February 19, 2026 06:47
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Visit the preview URL for this PR (updated for commit c125681):

https://yew-rs-api--pr3992-fix-hook-rust-2024-l-5vk6ld09.web.app

(expires Thu, 26 Feb 2026 06:48:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.222 291.770 291.359 0.163
Hello World 10 491.328 526.708 497.034 10.845
Function Router 10 1630.768 1653.976 1638.563 7.139
Concurrent Task 10 1005.609 1007.564 1006.500 0.664
Many Providers 10 1057.012 1100.083 1078.338 13.712

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.334 294.546 291.788 0.979
Hello World 10 473.253 480.396 476.027 1.923
Function Router 10 1653.389 1676.394 1664.966 7.804
Concurrent Task 10 1005.084 1007.184 1006.533 0.716
Many Providers 10 1065.255 1090.157 1075.179 7.652

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 96.833 96.833 0 0.000%
boids 165.479 165.479 0 0.000%
communication_child_to_parent 89.898 89.898 0 0.000%
communication_grandchild_with_grandparent 100.939 100.939 0 0.000%
communication_grandparent_to_grandchild 97.436 97.436 0 0.000%
communication_parent_to_child 87.314 87.314 0 0.000%
contexts 102.930 102.930 0 0.000%
counter 84.047 84.047 0 0.000%
counter_functional 85.393 85.393 0 0.000%
dyn_create_destroy_apps 87.123 87.123 0 0.000%
file_upload 96.572 96.572 0 0.000%
function_delayed_input 90.971 90.971 0 0.000%
function_memory_game 169.015 169.015 0 0.000%
function_router 326.375 326.375 0 0.000%
function_todomvc 160.920 160.920 0 0.000%
futures 232.377 232.377 0 0.000%
game_of_life 102.297 102.297 0 0.000%
immutable 244.699 244.699 0 0.000%
inner_html 78.628 78.628 0 0.000%
js_callback 107.431 107.431 0 0.000%
keyed_list 177.169 177.169 0 0.000%
mount_point 81.758 81.758 0 0.000%
nested_list 110.740 110.740 0 0.000%
node_refs 89.202 89.202 0 0.000%
password_strength 1726.270 1726.270 0 0.000%
portals 90.776 90.776 0 0.000%
router 297.119 297.119 0 0.000%
suspense 110.943 110.943 0 0.000%
timer 86.581 86.581 0 0.000%
timer_functional 96.105 96.105 0 0.000%
todomvc 139.516 139.516 0 0.000%
two_apps 83.909 83.909 0 0.000%
web_worker_fib 133.666 133.666 0 0.000%
web_worker_prime 184.621 184.621 0 0.000%
webgl 81.257 81.257 0 0.000%

✅ None of the examples has changed their size significantly.

@Madoshakalaka Madoshakalaka marked this pull request as ready for review February 19, 2026 06:55
@Madoshakalaka Madoshakalaka merged commit c174b14 into master Feb 19, 2026
25 checks passed
@Madoshakalaka Madoshakalaka added the A-yew-macro Area: The yew-macro crate label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-yew-macro Area: The yew-macro crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom hooks with RPIT no longer compile in Rust 2024

1 participant

Comments