Skip to content

fix: remove unstable config-include hack#4048

Merged
Madoshakalaka merged 2 commits intomasterfrom
fix/stable-config-include
Mar 6, 2026
Merged

fix: remove unstable config-include hack#4048
Madoshakalaka merged 2 commits intomasterfrom
fix/stable-config-include

Conversation

@Madoshakalaka
Copy link
Copy Markdown
Member

Rust 1.94 stabilized the include key in .cargo/config.toml.

Rust 1.94 stabilized the `include` key in `.cargo/config.toml`.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 100.272 100.272 0 0.000%
boids 168.099 168.099 0 0.000%
communication_child_to_parent 93.485 93.485 0 0.000%
communication_grandchild_with_grandparent 105.262 105.262 0 0.000%
communication_grandparent_to_grandchild 101.610 101.610 0 0.000%
communication_parent_to_child 90.899 90.899 0 0.000%
contexts 105.177 105.177 0 0.000%
counter 86.282 86.282 0 0.000%
counter_functional 88.276 88.276 0 0.000%
dyn_create_destroy_apps 90.322 90.322 0 0.000%
file_upload 99.377 99.377 0 0.000%
function_delayed_input 94.377 94.377 0 0.000%
function_memory_game 172.944 172.944 0 0.000%
function_router 406.599 406.599 0 0.000%
function_todomvc 164.163 164.163 0 0.000%
futures 235.191 235.191 0 0.000%
game_of_life 104.732 104.732 0 0.000%
immutable 255.891 255.891 0 0.000%
inner_html 80.803 80.803 0 0.000%
js_callback 109.401 109.401 0 0.000%
keyed_list 179.740 179.740 0 0.000%
mount_point 84.174 84.174 0 0.000%
nested_list 113.072 113.072 0 0.000%
node_refs 91.523 91.523 0 0.000%
password_strength 1729.185 1729.185 0 0.000%
portals 93.034 93.034 0 0.000%
router 377.158 377.158 0 0.000%
suspense 113.502 113.502 0 0.000%
timer 88.641 88.641 0 0.000%
timer_functional 98.881 98.881 0 0.000%
todomvc 142.114 142.114 0 0.000%
two_apps 86.176 86.176 0 0.000%
web_worker_fib 136.155 136.155 0 0.000%
web_worker_prime 187.383 187.383 0 0.000%
webgl 83.224 83.224 0 0.000%

✅ None of the examples has changed their size significantly.

@Madoshakalaka
Copy link
Copy Markdown
Member Author

@copilot rebase onto master

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 6, 2026

@Madoshakalaka I've opened a new pull request, #4050, to work on those changes. Once the pull request is ready, I'll request review from you.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

Visit the preview URL for this PR (updated for commit a18adaa):

https://yew-rs-api--pr4048-fix-stable-config-in-pr8rfcr1.web.app

(expires Fri, 13 Mar 2026 06:17:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.174 ns      │ 2.474 ns      │ 2.178 ns      │ 2.186 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.175 ns      │ 3.451 ns      │ 2.179 ns      │ 2.417 ns      │ 100     │ 1000000000

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 310.665 311.331 310.965 0.220
Hello World 10 476.252 489.534 479.955 4.755
Function Router 10 32638.418 32854.150 32754.158 68.361
Concurrent Task 10 1006.493 1007.898 1007.474 0.416
Many Providers 10 1074.206 1149.702 1103.475 30.702

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 310.836 311.580 311.133 0.240
Hello World 10 469.750 497.680 478.859 9.738
Function Router 10 31772.131 33268.543 32306.597 459.202
Concurrent Task 10 1006.385 1007.700 1007.152 0.437
Many Providers 10 1098.155 1148.598 1119.556 20.392

@Madoshakalaka Madoshakalaka marked this pull request as ready for review March 6, 2026 07:07
@Madoshakalaka Madoshakalaka merged commit fb2046c into master Mar 6, 2026
35 checks passed
Comment on lines -1 to -2
[target.wasm32-unknown-unknown]
rustflags = ["--cfg", "nightly_yew"]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that setting RUSTFLAGS as an environment variable does not merge with rustflags from config tomls, which is why I thought this would be cleaner. It seems there is no workaround to set these always when a nightly compiler is used now :/ Ref: rust-lang/cargo#14733

Any way, the only other place that is currently using rustflags I suppose is

[target.wasm32-unknown-unknown]
rustflags = ['--cfg', 'getrandom_backend="wasm_js"']
which is for an example only which doesn't need to use nightly_yew, so we are fine!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if this PR actually changed the actual flags passed and would cause problems.

Thanks for the confirmation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants