fix: remove unstable config-include hack#4048
Conversation
Rust 1.94 stabilized the `include` key in `.cargo/config.toml`.
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
|
@copilot rebase onto master |
|
@Madoshakalaka I've opened a new pull request, #4050, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
Visit the preview URL for this PR (updated for commit a18adaa): https://yew-rs-api--pr4048-fix-stable-config-in-pr8rfcr1.web.app (expires Fri, 13 Mar 2026 06:17:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
| [target.wasm32-unknown-unknown] | ||
| rustflags = ["--cfg", "nightly_yew"] |
There was a problem hiding this comment.
Note that setting RUSTFLAGS as an environment variable does not merge with rustflags from config tomls, which is why I thought this would be cleaner. It seems there is no workaround to set these always when a nightly compiler is used now :/ Ref: rust-lang/cargo#14733
Any way, the only other place that is currently using rustflags I suppose is
Lines 7 to 8 in fb2046c
There was a problem hiding this comment.
I was wondering if this PR actually changed the actual flags passed and would cause problems.
Thanks for the confirmation!
Rust 1.94 stabilized the
includekey in.cargo/config.toml.