fix: bump minimum web-sys to 0.3.70#4100
Merged
Madoshakalaka merged 2 commits intomasterfrom Apr 2, 2026
Merged
Conversation
Yew uses `set_passive()`/`set_capture()` which were introduced in web-sys 0.3.70, but the workspace dependency allowed any 0.3.x. This caused compilation failures when the resolver picked an older web-sys.
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
WorldSEnder
approved these changes
Apr 2, 2026
Member
WorldSEnder
left a comment
There was a problem hiding this comment.
Thanks. Note, this was part of the initial fix but seems to got swept under when they got converted to workspace deps, A quick scan reveals the following packages that also got their patch version unbumped: serde, thiserror, reqwest, js_sys. The only one of those that I can see causing a similar issue is js_sys that is a dep of web_sys and gets pull in via this regardless.
Member
Author
|
I see. Actually my mistake |
shan-shaji
pushed a commit
to shan-shaji/yew
that referenced
this pull request
Apr 19, 2026
Yew uses `set_passive()`/`set_capture()` which were introduced in web-sys 0.3.70, but the workspace dependency allowed any 0.3.x. This caused compilation failures when the resolver picked an older web-sys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported on discord.
This is a sneaky error introduced since aa21119 (two years ago). It can cause a compile error when somebody picks up a 2 year old project again.