Skip to content

fix: bump minimum web-sys to 0.3.70#4100

Merged
Madoshakalaka merged 2 commits intomasterfrom
fix/web-sys-min-version
Apr 2, 2026
Merged

fix: bump minimum web-sys to 0.3.70#4100
Madoshakalaka merged 2 commits intomasterfrom
fix/web-sys-min-version

Conversation

@Madoshakalaka
Copy link
Copy Markdown
Member

@Madoshakalaka Madoshakalaka commented Apr 2, 2026

Reported on discord.

This is a sneaky error introduced since aa21119 (two years ago). It can cause a compile error when somebody picks up a 2 year old project again.

Yew uses `set_passive()`/`set_capture()` which were introduced in
web-sys 0.3.70, but the workspace dependency allowed any 0.3.x.
This caused compilation failures when the resolver picked an older
web-sys.
@Madoshakalaka Madoshakalaka added the A-yew Area: The main yew crate label Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 100.819 100.819 0 0.000%
boids 168.450 168.450 0 0.000%
communication_child_to_parent 94.073 94.073 0 0.000%
communication_grandchild_with_grandparent 105.916 105.916 0 0.000%
communication_grandparent_to_grandchild 102.260 102.260 0 0.000%
communication_parent_to_child 91.485 91.485 0 0.000%
contexts 105.973 105.973 0 0.000%
counter 86.797 86.797 0 0.000%
counter_functional 88.832 88.832 0 0.000%
dyn_create_destroy_apps 90.711 90.711 0 0.000%
file_upload 99.811 99.811 0 0.000%
function_delayed_input 94.807 94.807 0 0.000%
function_memory_game 173.667 173.667 0 0.000%
function_router 395.661 395.661 0 0.000%
function_todomvc 164.958 164.958 0 0.000%
futures 235.550 235.550 0 0.000%
game_of_life 105.098 105.098 0 0.000%
immutable 259.500 259.500 0 0.000%
inner_html 81.340 81.340 0 0.000%
js_callback 109.963 109.963 0 0.000%
keyed_list 180.403 180.403 0 0.000%
mount_point 84.712 84.712 0 0.000%
nested_list 113.656 113.656 0 0.000%
node_refs 92.086 92.086 0 0.000%
password_strength 1719.252 1719.252 0 0.000%
portals 93.558 93.558 0 0.000%
router 366.305 366.305 0 0.000%
suspense 113.961 113.961 0 0.000%
timer 88.942 88.942 0 0.000%
timer_functional 99.369 99.369 0 0.000%
todomvc 142.660 142.660 0 0.000%
two_apps 86.710 86.710 0 0.000%
web_worker_fib 136.459 136.459 0 0.000%
web_worker_prime 187.641 187.641 0 0.000%
webgl 83.485 83.485 0 0.000%

✅ None of the examples has changed their size significantly.

Copy link
Copy Markdown
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Note, this was part of the initial fix but seems to got swept under when they got converted to workspace deps, A quick scan reveals the following packages that also got their patch version unbumped: serde, thiserror, reqwest, js_sys. The only one of those that I can see causing a similar issue is js_sys that is a dep of web_sys and gets pull in via this regardless.

@Madoshakalaka
Copy link
Copy Markdown
Member Author

I see. Actually my mistake

@Madoshakalaka Madoshakalaka merged commit 13841df into master Apr 2, 2026
30 checks passed
@Madoshakalaka Madoshakalaka deleted the fix/web-sys-min-version branch April 2, 2026 16:03
shan-shaji pushed a commit to shan-shaji/yew that referenced this pull request Apr 19, 2026
Yew uses `set_passive()`/`set_capture()` which were introduced in web-sys 0.3.70, but the workspace dependency allowed any 0.3.x. This caused compilation failures when the resolver picked an older web-sys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-yew Area: The main yew crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants