Skip to content

refactor: un-vendor gloo-worker from yew-agent#4106

Merged
Madoshakalaka merged 1 commit intomasterfrom
unvendor-gloo-worker
Apr 4, 2026
Merged

refactor: un-vendor gloo-worker from yew-agent#4106
Madoshakalaka merged 1 commit intomasterfrom
unvendor-gloo-worker

Conversation

@Madoshakalaka
Copy link
Copy Markdown
Member

@Madoshakalaka Madoshakalaka commented Apr 3, 2026

Description

Un-vendor gloo-worker from yew-agent, switching back to the upstream gloo-worker = "0.6" crate dependency.

We originally vendored gloo-worker in #3859 (thanks to @LucaCappelletti94 ) because the upstream crate (v0.5) lacked module worker type support (WorkerType::Module). gloo-worker 0.6.0 now ships that feature via the as_module() method on all spawners, so the vendored copy is no longer needed.

Checklist

  • I have reviewed my own code

gloo-worker 0.6.0 now ships with module worker type support
(the `as_module()` method on all spawners), which was the reason
we vendored it in the first place.
@Madoshakalaka Madoshakalaka added the A-yew-agent Area: The yew-agent crate label Apr 3, 2026
@LucaCappelletti94
Copy link
Copy Markdown
Contributor

Thanks for this work!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

Visit the preview URL for this PR (updated for commit 1737770):

https://yew-rs-api--pr4106-unvendor-gloo-worker-8ku2zrc4.web.app

(expires Fri, 10 Apr 2026 07:43:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 100.858 100.858 0 0.000%
boids 168.452 168.452 0 0.000%
communication_child_to_parent 94.075 94.075 0 0.000%
communication_grandchild_with_grandparent 105.913 105.913 0 0.000%
communication_grandparent_to_grandchild 102.260 102.260 0 0.000%
communication_parent_to_child 91.485 91.485 0 0.000%
contexts 105.973 105.980 +0.008 +0.007%
counter 86.797 86.797 0 0.000%
counter_functional 88.833 88.833 0 0.000%
dyn_create_destroy_apps 90.714 90.714 0 0.000%
file_upload 99.811 99.811 0 0.000%
function_delayed_input 94.803 94.803 0 0.000%
function_memory_game 173.666 173.666 0 0.000%
function_router 395.506 395.506 0 0.000%
function_todomvc 164.954 164.954 0 0.000%
futures 235.550 235.550 0 0.000%
game_of_life 105.098 105.098 0 0.000%
immutable 259.581 259.581 0 0.000%
inner_html 81.340 81.340 0 0.000%
js_callback 109.961 109.961 0 0.000%
keyed_list 180.407 180.407 0 0.000%
mount_point 84.714 84.714 0 0.000%
nested_list 113.659 113.659 0 0.000%
node_refs 92.087 92.087 0 0.000%
password_strength 1719.253 1719.253 0 0.000%
portals 93.560 93.560 0 0.000%
router 366.146 366.146 0 0.000%
suspense 113.966 113.966 0 0.000%
timer 88.942 88.942 0 0.000%
timer_functional 99.369 99.369 0 0.000%
todomvc 142.660 142.660 0 0.000%
two_apps 86.710 86.710 0 0.000%
web_worker_fib 136.459 136.417 -0.042 -0.031%
web_worker_prime 187.646 184.826 -2.820 -1.503%
webgl 83.486 83.486 0 0.000%

⚠️ The following example has changed its size significantly:

examples master (KB) pull request (KB) diff (KB) diff (%)
web_worker_prime 187.646 184.826 -2.820 -1.503%

@Madoshakalaka Madoshakalaka marked this pull request as ready for review April 3, 2026 07:55
@Madoshakalaka Madoshakalaka merged commit 92904ce into master Apr 4, 2026
36 checks passed
@Madoshakalaka Madoshakalaka deleted the unvendor-gloo-worker branch April 4, 2026 09:31
shan-shaji pushed a commit to shan-shaji/yew that referenced this pull request Apr 19, 2026
gloo-worker 0.6.0 now ships with module worker type support
(the `as_module()` method on all spawners), which was the reason
we vendored it in the first place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-yew-agent Area: The yew-agent crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants