refactor: un-vendor gloo-worker from yew-agent#4106
Merged
Madoshakalaka merged 1 commit intomasterfrom Apr 4, 2026
Merged
Conversation
gloo-worker 0.6.0 now ships with module worker type support (the `as_module()` method on all spawners), which was the reason we vendored it in the first place.
Contributor
|
Thanks for this work! |
|
Visit the preview URL for this PR (updated for commit 1737770): https://yew-rs-api--pr4106-unvendor-gloo-worker-8ku2zrc4.web.app (expires Fri, 10 Apr 2026 07:43:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size ComparisonDetails
|
shan-shaji
pushed a commit
to shan-shaji/yew
that referenced
this pull request
Apr 19, 2026
gloo-worker 0.6.0 now ships with module worker type support (the `as_module()` method on all spawners), which was the reason we vendored it in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Un-vendor gloo-worker from yew-agent, switching back to the upstream
gloo-worker = "0.6"crate dependency.We originally vendored gloo-worker in #3859 (thanks to @LucaCappelletti94 ) because the upstream crate (v0.5) lacked module worker type support (
WorkerType::Module). gloo-worker 0.6.0 now ships that feature via theas_module()method on all spawners, so the vendored copy is no longer needed.Checklist