Skip to content

Bincode support#714

Closed
serzhiio wants to merge 0 commit into
yewstack:masterfrom
serzhiio:master
Closed

Bincode support#714
serzhiio wants to merge 0 commit into
yewstack:masterfrom
serzhiio:master

Conversation

@serzhiio

Copy link
Copy Markdown
Contributor

Added Bincode support as WS messaging format, updated bincode dep version
#413

@jstarry

jstarry commented Oct 20, 2019

Copy link
Copy Markdown
Member

Thanks @serzhiio, looks like Bincode is broken for Emscripten so we'll have to wait a bit until this merges: bincode-org/bincode#281

@jstarry jstarry added this to the 0.10.1 milestone Nov 11, 2019
@jstarry jstarry added the blocked label Dec 8, 2019
@jstarry

jstarry commented Dec 10, 2019

Copy link
Copy Markdown
Member

Ok, the upstream PR has merged, now just waiting on the next release of bincode 😄

@jstarry jstarry removed the blocked label Dec 10, 2019
@jstarry

jstarry commented Dec 10, 2019

Copy link
Copy Markdown
Member

Bincode 1.2.1 has been released 🎉

Changes needed:

  • Feature for enabling/disabling bincode
  • Update to bincode 1.2.1
  • Remove = restriction on bincode version

@jstarry

jstarry commented Dec 15, 2019

Copy link
Copy Markdown
Member

For whatever reason, when I updated this PR's branch, it auto-closed 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants