fix: render hours using useIsomorphicLayoutEffect#147
Conversation
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 46 minutes and 12 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
benlife5
left a comment
There was a problem hiding this comment.
Whether to use useLayoutEffect for an hours component is the sort of debate that ChatGPT will either support or argue against depending on which way you lean on it. Seems like there might be a slight performance hit but I think it's worth not painting blank (status) or static content (table) and then re-painting with the correct data
This is to fix the client-computed hours renderings before the paint. useEffect results in a blank painted frame. This led to issues with tests in visual-editor thinking the hours were properly rendered before they really were.