fix: handle mapbox padding race condition (v1.11.1) #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Current unit coverage is 89.86632169038378% |
Fondryext
previously approved these changes
Dec 17, 2025
Fondryext
previously approved these changes
Dec 17, 2025
Fondryext
approved these changes
Dec 17, 2025
k-gerner
added a commit
to yext/visual-editor
that referenced
this pull request
Dec 17, 2025
This will pick up the locator map bug fix from here: yext/search-ui-react#592 J=[WAT-5090](https://yext.atlassian.net/browse/WAT-5090?atlOrigin=eyJpIjoiNmYyNTk2ZjMwYzZjNGYzMWE5OGRhOGQyODg1NDM3N2MiLCJwIjoiaiJ9) TEST=manual Tested search-ui-react tarball package and saw it work --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Rakesh Keerthi <108081082+rkeerthient@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Life <77246839+benlife5@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the map canvas has not been initialized / created with the expected height, we could pass in padding values that are too large for the canvas, causing a computational error in the Mapbox library. We now make sure that the padding fits within the map canvas
J=WAT-5090
TEST=manual
packed tarball and used in VLE site that was having issues prior. Saw the issues no longer happen