chore: upgrade mapbox-gl version for accessibility issues (v3.0.0)#654
chore: upgrade mapbox-gl version for accessibility issues (v3.0.0)#654anguyen-yext2 wants to merge 9 commits intomainfrom
Conversation
current version has some accessibility issues that will be addressed by this upgrade J=WAT-5461 TEST=manual verified test-site still function as expected platform testing: 1. pack the change along 2. upgrade the mapbox versions in pages-component and pack that change 3. reference those packed versions in VE and starter 4. swapped branch and confirmed there is no longer any accessibility errors on live site
|
Why does this require a major version upgrade? |
Legal RiskThe following dependencies were released under a license that RecommendationReach out to your security team or Semgrep admin to address this issue. In special cases, exceptions may be made for dependencies with violating licenses, however, the general recommendation is to avoid using a dependency under such a license non-standard |
|
Current unit coverage is 89.79427188382412% |
Because our public types expose Mapbox types (mapboxgl.MapboxOptions, LngLatBounds, etc.), so consumers can see breaking type/runtime differences even though our component props didn’t change. |
…ed, version-stable interfaces
@types/mapbox-glimport sincemapbox-glprovides its own typesThis PR also includes some improvements that I noticed when testing:
J=WAT-5461
TEST=auto,manual
verified test-site still function as expected
verified that locator functions as expected and that there is no longer any accessibility errors on live site