fix: default layout and qa nits

[benlife5]

• Header links was missing xs size option
• Header links were missing some defaultProps
• Video label was sometimes duplicated
• Text list input auto-focus was broken by Puck changes
• Locator default layout was broken by a bad change to the meta title

[github-actions]

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

Adds default weight: "normal" to HeaderLinks styles and updates HeaderLinks.resolveFields to conditionally show alignment and collapsed-links fields based on parent header slot. Applies the new weight default to SecondaryHeaderSlot and adds corresponding migration updates to include align and weight on header link styles. Bumps multiple defaultLayoutData versions and converts many BodyTextSlot instances to TextSlot with added fontStyle/variant/weight attributes. Introduces an "Extra Small" body variant option and translations across locales. Refactors TextList focus logic via a getFocusableChild helper and adds a Video target to removeDuplicateActionBars.

Sequence Diagram(s)

(omitted)

Possibly related PRs

• refactor: header improvements #1001: Overlapping changes to HeaderLinks defaults and resolveFields visibility logic.
• fix: text list constant value input #1029: Modifies TextList focus/observer behavior in the same file as this PR’s refactor.
• chore: update screenshots batch 1 #985: Related edits to HeaderLinks (translations/ARIA and link behavior) affecting the same component.

Suggested labels

create-dev-release

Suggested reviewers

• briantstephan
• mkilpatrick
• asanehisa

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix: default layout and qa nits' is vague and does not clearly convey what the primary changes are, using generic terms like 'nits' that lack specificity.	Revise the title to be more specific, such as 'fix: header links sizing, focus behavior, and layout issues' to better communicate the main changes.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is well-related to the changeset, listing five specific issues that are addressed: header links sizing, missing defaultProps, duplicated video labels, text list focus issues, and locator layout problems.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch release-qa-1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

packages/visual-editor/locales/platform/zh-TW/visual-editor.json (1)

293-293: Minor translation inconsistency: "號" suffix not used by sibling size entries.

The new value "特小號" includes the size classifier 號, while the existing peer entries omit it:

Key	Value
"small_text size"	"小"
"large_text size"	"大"
"extraSmall_text size"	"特小號" ← inconsistent

Both "特小" and "特小號" are idiomatic Traditional Chinese for "extra small", but dropping 號 would align with the established pattern. Consider "特小" for consistency.

♻️ Proposed consistency fix

-      "extraSmall_text size": "特小號",
+      "extraSmall_text size": "特小",

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/visual-editor/locales/platform/zh-TW/visual-editor.json` at line
293, The translation value for the "extraSmall_text size" key is inconsistent
with sibling entries ("small_text size", "large_text size") because it includes
the suffix "號"; update the value from "特小號" to "特小" so it matches the existing
pattern and maintains consistency across size labels (locate the
"extraSmall_text size" JSON entry and replace the value accordingly).

packages/visual-editor/locales/platform/zh/visual-editor.json (1)

293-293: LGTM — minor translation-style nit (optional)

The key "extraSmall_text size" correctly follows the <variant>_text size naming convention and is alphabetically placed between "end" and "facets".

The translation "特小号" is natural and unambiguous Chinese for "extra small." The only cosmetic difference is that the neighbouring size entries use terse single-character values ("大", "小"), while "特小号" carries the explicit size-designator suffix 号. "特小" alone would mirror that terse style, but "特小号" is equally correct and arguably clearer to end-users. No action required.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/visual-editor/locales/platform/zh/visual-editor.json` at line 293,
The translation for the key "extraSmall_text size" currently uses "特小号"; if you
want to make it stylistically consistent with neighboring single-character size
values, change the value to "特小" by updating the JSON entry for "extraSmall_text
size" (leave the key unchanged) so it matches terse style used for "大" and "小";
this change is optional since "特小号" is also correct.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/visual-editor/locales/platform/en/visual-editor.json`:
- Line 293: The i18n keys for text-size options must match the option values
used in themeConfigOptions.ts (e.g., `${optionValue}_text size`), so update the
keys currently named "extraSmall_text size", "small_text size", and "large_text
size" to "xs_text size", "sm_text size", and "lg_text size" respectively
(confirm "base_text size" stays as-is), and apply the same change across all 25
locale files so the runtime lookup using the option values (xs, sm, lg) resolves
correctly.

---

Nitpick comments:
In `@packages/visual-editor/locales/platform/zh-TW/visual-editor.json`:
- Line 293: The translation value for the "extraSmall_text size" key is
inconsistent with sibling entries ("small_text size", "large_text size") because
it includes the suffix "號"; update the value from "特小號" to "特小" so it matches
the existing pattern and maintains consistency across size labels (locate the
"extraSmall_text size" JSON entry and replace the value accordingly).

In `@packages/visual-editor/locales/platform/zh/visual-editor.json`:
- Line 293: The translation for the key "extraSmall_text size" currently uses
"特小号"; if you want to make it stylistically consistent with neighboring
single-character size values, change the value to "特小" by updating the JSON
entry for "extraSmall_text size" (leave the key unchanged) so it matches terse
style used for "大" and "小"; this change is optional since "特小号" is also correct.