feat: update component generation to remove chakra#1091
feat: update component generation to remove chakra#1091jwartofsky-yext merged 7 commits intocomponent-genfrom
Conversation
Component generation skill was setup to use Chakra for all components This changes it to use react/html components instead
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis pull request removes the Chakra UI dependency and related imports from the starter project and replaces Chakra components with semantic HTML and Tailwind-style classes. Changes: deleted Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can generate walkthrough in a markdown collapsible section to save space.Enable the |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
starter/skills/vle-generate-components/references/ExampleSection.tsx (1)
74-75:⚠️ Potential issue | 🟡 Minor
"normal"is not a valid CSStext-transformvalue.The CSS
text-transformproperty acceptsnone,capitalize,uppercase,lowercase,full-width, etc., but not"normal". This should be"none"for the default/no-transform case. This affects both the type definition (line 26) and the select options here.Proposed fix
textTransform: { label: "Text Transform", type: "select", options: [ - { label: "Normal", value: "normal" }, + { label: "None", value: "none" }, { label: "Uppercase", value: "uppercase" }, { label: "Lowercase", value: "lowercase" }, { label: "Capitalize", value: "capitalize" }, ], },Also update the type definition at line 26:
- textTransform: "normal" | "uppercase" | "lowercase" | "capitalize"; + textTransform: "none" | "uppercase" | "lowercase" | "capitalize";And the defaultProps at line 168:
- textTransform: "normal", + textTransform: "none",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@starter/skills/vle-generate-components/references/ExampleSection.tsx` around lines 74 - 75, The select option uses an invalid CSS text-transform value "normal"—replace that option value with "none" and update the corresponding type and default to match; specifically, in ExampleSection replace the options entry { label: "Normal", value: "normal" } with value "none", update the text-transform union/type used for the prop (the TextTransform/type in the ExampleSection props/type definition) to include "none" instead of "normal", and change the component's defaultProps/default value for the textTransform prop to "none" so types, options array, and defaults are consistent with valid CSS values.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@starter/skills/vle-generate-components/references/ExampleSection.tsx`:
- Around line 74-75: The select option uses an invalid CSS text-transform value
"normal"—replace that option value with "none" and update the corresponding type
and default to match; specifically, in ExampleSection replace the options entry
{ label: "Normal", value: "normal" } with value "none", update the
text-transform union/type used for the prop (the TextTransform/type in the
ExampleSection props/type definition) to include "none" instead of "normal", and
change the component's defaultProps/default value for the textTransform prop to
"none" so types, options array, and defaults are consistent with valid CSS
values.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 7d708023-e881-4376-a398-060c60992564
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
starter/package.jsonstarter/skills/vle-generate-components/SKILL.mdstarter/skills/vle-generate-components/references/ExampleSection.tsxstarter/skills/vle-generate-components/references/generation-requirements.mdstarter/src/templates/dev.tsxstarter/src/ve.config.tsx
💤 Files with no reviewable changes (1)
- starter/package.json
asanehisa
left a comment
There was a problem hiding this comment.
lgtm hopefully it generates well still? did u generate sweetgreen with this?
Yup! |
The component generation skill was setup to use Chakra for all components
This changes it to use react/html components instead