Skip to content

refactor: dateTimeSelector fieldType#1160

Merged
mkilpatrick merged 4 commits intomainfrom
date-time-selector
Apr 16, 2026
Merged

refactor: dateTimeSelector fieldType#1160
mkilpatrick merged 4 commits intomainfrom
date-time-selector

Conversation

@mkilpatrick
Copy link
Copy Markdown
Collaborator

Makes dateTimeSelector a real fieldType.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 15, 2026

Warning

Rate limit exceeded

@yext-bot has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 38 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 29 minutes and 38 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d69b9ae9-eca5-4c9e-98ff-954279dcd75f

📥 Commits

Reviewing files that changed from the base of the PR and between 5d141b9 and 0bd1aa4.

⛔ Files ignored due to path filters (1)
  • packages/visual-editor/src/components/testing/screenshots/Locator/[tablet] latest version default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
📒 Files selected for processing (26)
  • packages/visual-editor/locales/platform/cs/visual-editor.json
  • packages/visual-editor/locales/platform/da/visual-editor.json
  • packages/visual-editor/locales/platform/de/visual-editor.json
  • packages/visual-editor/locales/platform/en-GB/visual-editor.json
  • packages/visual-editor/locales/platform/en/visual-editor.json
  • packages/visual-editor/locales/platform/es/visual-editor.json
  • packages/visual-editor/locales/platform/et/visual-editor.json
  • packages/visual-editor/locales/platform/fi/visual-editor.json
  • packages/visual-editor/locales/platform/fr/visual-editor.json
  • packages/visual-editor/locales/platform/hr/visual-editor.json
  • packages/visual-editor/locales/platform/hu/visual-editor.json
  • packages/visual-editor/locales/platform/it/visual-editor.json
  • packages/visual-editor/locales/platform/ja/visual-editor.json
  • packages/visual-editor/locales/platform/lt/visual-editor.json
  • packages/visual-editor/locales/platform/lv/visual-editor.json
  • packages/visual-editor/locales/platform/nb/visual-editor.json
  • packages/visual-editor/locales/platform/nl/visual-editor.json
  • packages/visual-editor/locales/platform/pl/visual-editor.json
  • packages/visual-editor/locales/platform/pt/visual-editor.json
  • packages/visual-editor/locales/platform/ro/visual-editor.json
  • packages/visual-editor/locales/platform/sk/visual-editor.json
  • packages/visual-editor/locales/platform/sv/visual-editor.json
  • packages/visual-editor/locales/platform/tr/visual-editor.json
  • packages/visual-editor/locales/platform/zh-TW/visual-editor.json
  • packages/visual-editor/locales/platform/zh/visual-editor.json
  • packages/visual-editor/src/fields/DateTimeSelectorField.tsx

Walkthrough

This PR introduces a new DateTimeSelectorField component that provides a dedicated field override for datetime input rendering. The change refactors constant field configuration typing by introducing a ConstantFieldConfig union type that accommodates both traditional Field types and Yext Puck field configs. The old DateTimeSelector component is removed from internal Puck components and replaced with the new field system integration. The ConstantValueInput is updated to use YextAutoField for rendering non-string field editors and treats Yext Puck field configs similarly to custom configs during rendering.

Possibly related PRs

Suggested reviewers

  • briantstephan
  • mkilpatrick
  • jwartofsky-yext
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: refactoring dateTimeSelector to be a proper fieldType rather than a custom field component.
Description check ✅ Passed The description directly relates to the changeset by explaining that dateTimeSelector is being converted from a custom field to a real fieldType.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch date-time-selector

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

⚠️ Deleted Translation Keys Detected

🔤 Deleted Translation Keys

dateAndTime

Key Languages Removed
dateAndTime cs,da de,en en-GB,es et,fi fr,hr hu,it ja,lt lv,nb nl,pl pt,ro sk,sv tr,zh zh-TW

@mkilpatrick mkilpatrick requested review from asanehisa, benlife5, briantstephan and jwartofsky-yext and removed request for benlife5 April 15, 2026 21:31
@mkilpatrick mkilpatrick merged commit e533d06 into main Apr 16, 2026
17 checks passed
@mkilpatrick mkilpatrick deleted the date-time-selector branch April 16, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants