Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/visual-editor/src/components/header/HeaderLinks.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -342,13 +342,20 @@ const HeaderLinksComponent: PuckComponent<HeaderLinksProps> = ({
className={`flex flex-col w-full sm:w-auto gap-0 ${
displayMode === "menu"
? isDesktop
? "md:flex-row md:gap-6 md:items-center justify-end"
? "md:flex-row md:flex-wrap md:items-start justify-end md:gap-x-6 md:gap-y-4"
: "justify-start"
: `${justifyClass} md:flex-row md:gap-6`
: `w-full sm:w-auto ${justifyClass} md:flex-row md:gap-6`
} ${sizeClass} ${weightClass}`}
>
{linksToRender.map((item, i) => (
<li key={`visible-${i}`} className="py-4 lg:py-0">
<li
key={`visible-${i}`}
className={
displayMode === "menu"
? "min-w-0 py-4 sm:max-w-full sm:basis-auto lg:py-0"
: "py-4 lg:py-0"
}
>
{renderLink(item, i)}
</li>
))}
Expand Down
Comment thread
jwartofsky-yext marked this conversation as resolved.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we're ok wrapping the links like this instead of text-wrapping the link names themselves when the link names are long. I could see arguments either way, so what you have now is probably fine and more consistent.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@briantstephan briantstephan Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we want to try to avoid line wrapping when possible and maybe use a menu when it happens.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Comment thread
jwartofsky-yext marked this conversation as resolved.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading