-
Notifications
You must be signed in to change notification settings - Fork 1
fix: handle overflow in header links #1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d6994ed
641ede1
e22ebf9
d4534bd
2285db2
ffeb475
04605f4
4352ee3
8b89110
6ef5944
07aed9f
ea6f8eb
0bbfd6f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM as long as we're ok wrapping the links like this instead of text-wrapping the link names themselves when the link names are long. I could see arguments either way, so what you have now is probably fine and more consistent.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Posted here to get an answer: https://yext.slack.com/archives/C0A1G447MPD/p1776882017304429
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like we want to try to avoid line wrapping when possible and maybe use a menu when it happens. |
|
jwartofsky-yext marked this conversation as resolved.
|
Uh oh!
There was an error while loading. Please reload this page.