-
Notifications
You must be signed in to change notification settings - Fork 0
feat: placeholder image for header/footer logo #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information. |
WalkthroughThis PR updates default image sources and aspect ratios across the visual editor. Multiple placeholder image URLs were replaced with new a.mktgcdn.com URLs (196x196 variants) in header, footer, team cards, and default layout data. Several image slot aspectRatio values were standardized from 1.78 or 2 to 1 (square). TeamCard sizing was changed to a fixed base size of 80px, removing prior responsive large-screen sizing. Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Also switches the team section to use an a.mktgcdn.com link with a better `sizes` prop set --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Also switches the team section to use an a.mktgcdn.com link with a better
sizesprop set