Skip to content

Conversation

@benlife5
Copy link
Contributor

Also switches the team section to use an a.mktgcdn.com link with a better sizes prop set

@github-actions
Copy link
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Walkthrough

This PR updates default image sources and aspect ratios across the visual editor. Multiple placeholder image URLs were replaced with new a.mktgcdn.com URLs (196x196 variants) in header, footer, team cards, and default layout data. Several image slot aspectRatio values were standardized from 1.78 or 2 to 1 (square). TeamCard sizing was changed to a fixed base size of 80px, removing prior responsive large-screen sizing.

Possibly related PRs

Suggested labels

create-dev-release

Suggested reviewers

  • mkilpatrick
  • colton-demetriou
  • briantstephan

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: placeholder image for header/footer logo' accurately describes the main changes across multiple files, focusing on placeholder images and aspect ratio adjustments in header and footer components.
Description check ✅ Passed The description mentions both main aspects of the changeset: placeholder images for header/footer and the team section update with improved CDN links and sizing properties.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-placeholder-images

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f846e94 and 3f25424.

⛔ Files ignored due to path filters (3)
  • packages/visual-editor/src/components/testing/screenshots/ExpandedHeader/[desktop] default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
  • packages/visual-editor/src/components/testing/screenshots/ExpandedHeader/[mobile] default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
  • packages/visual-editor/src/components/testing/screenshots/ExpandedHeader/[tablet] default props.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
📒 Files selected for processing (1)
  • packages/visual-editor/src/components/footer/ExpandedFooter.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: call_unit_test / unit_tests (18.x)
  • GitHub Check: call_unit_test / unit_tests (20.x)
  • GitHub Check: semgrep/ci
🔇 Additional comments (2)
packages/visual-editor/src/components/footer/ExpandedFooter.tsx (2)

332-332: LGTM! Aspect ratio correctly updated for square logo.

The aspect ratio change from 1.78 to 1 is correct for the square 196x196 placeholder image, ensuring the logo displays without distortion.


15-16: Placeholder image URL is verified and accessible.

The new a.mktgcdn.com URL for the square logo (196x196) returns a valid HTTP 200 response with proper public access headers and strong caching (1-year TTL), indicating a stable, permanently hosted resource.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@benlife5 benlife5 merged commit f6272d9 into main Dec 16, 2025
15 checks passed
@benlife5 benlife5 deleted the update-placeholder-images branch December 16, 2025 19:17
k-gerner pushed a commit that referenced this pull request Dec 17, 2025
Also switches the team section to use an a.mktgcdn.com link with a
better `sizes` prop set

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants