chore: remove dead Go symbols, JS modules, and CSS rules#61
Merged
Conversation
Drop unreferenced Go functions (test-claimed setters never called,
orphaned export/template helpers), two dead JS modules (a superseded
mobile command panel and a re-export shim), and 18 unused CSS classes
left over from earlier menu/model-selector redesigns.
The palette shim's test was the only coverage for the shared
session-list-palette implementation, so it moves beside that source
and imports it directly. Dynamically-built classes (thinking-${level},
concat-generated menu section classes) are preserved.
…-90bf # Conflicts: # internal/ui/export.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure dead-code removal across Go, JS, and CSS — no behavior change. Each
removal was verified unreferenced (
deadcodefor Go, import-graph andfull-repo grep for JS/CSS), with dynamically-constructed class names
explicitly preserved.
Server.SetShareRunner/Server.SetMetricsSampler(test-claimed setters never called; tests setthe fields via struct literals), the orphaned
serveStaticJS,replaceRequired, and an unused test helper.mobile-command-panel.js(superseded bycommand-menu.js)and the dead
list-sessions-palette.jsre-export shim.shared/session-list-palette.js, so it moves beside that source andimports the real implementation directly.
model-selector redesigns (e.g.
model-dropdown*,command-menu-toggle,web-menu-separator). Dynamically-built classes (thinking-${level},concat-generated menu
*-sectionclasses) were kept.Related issue
Closes #
Type of change
chore— build, tooling, or maintenanceLive vs. Export
internal/ui/live_templates/in sync withweb/src/session/changesThe removed CSS lives in
internal/ui/live_templates/styles/(shared by boththe live app and the export snapshot); the dropped classes were dead in both
paths. No live-only chrome was involved.
Testing
make checkpasses (test + build + vet)vitest) cover the change — 488 passinggo test ./...) cover the change