test(e2e): make cat gatekeeper test time-independent#76
Merged
Conversation
The cat gatekeeper's bedtime "sleep" overlay (default 23:00-07:00) is driven by the live browser Date.now(), so skip-to-break showed the sleepy cat instead of the break whenever CI ran during that window. Use page.clock.setFixedTime() to pin a non-bedtime hour (setFixedTime, not install, so app timers keep running).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tests/cat.spec.ts(skip-to-break shows the enforced break overlay) is flaky by time of day: the cat gatekeeper's bedtime "sleep" overlay (default window 23:00–07:00) is computed from the live browserDate.now(). When CI runs inside that window,skipToBreak()shows the sleepy cat (cat-overlay--sleep) instead of the break, so the test fails:It passes during the day and fails at night (UTC), across all browser projects.
Fix
Pin the browser clock to a fixed non-bedtime hour with Playwright's
page.clock.setFixedTime()(set before navigation). UsessetFixedTimerather thanclock.install()so the app's other timers (status polling, SSE) keep running normally.Verification
Run during the bedtime window (where it previously failed) — now green across Desktop Chrome / Mobile Safari / iPad:
One-line test-only change; no product code touched.