fix(web): WCO header alignment, session loading spinner, SPA back link#84
Merged
Conversation
The header inner box is centered (max-width + margin: auto) to match the .content cards below. In window-controls-overlay mode it unconditionally added the titlebar-area-x inset to padding-left, pushing the logo right of the cards on wide windows where the centered box already clears the OS controls. Only apply the inset when the box would slide under the controls.
The .session-loading element had no CSS, so the "Loading session…" string rendered as unstyled text in the top-left corner and flashed away. Give it a full-viewport centered layout with a spinner (reusing the existing spin keyframe), a muted label, and a gentle fade-in, and style the error fallback.
The "← Back" link was a plain <a href="/">, triggering a full document reload. Under the cross-document view transition that reload could stall in the installed PWA, leaving the homepage stuck on "Loading sessions…". Route it through handleNavClick like the session cards so it navigates client-side, while still honoring modified clicks for open-in-new-tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three related web/PWA fixes:
env(titlebar-area-x)to.header-inner's left padding, pushing the logo ~90px right of the content cards on wide windows where the centeredmax-width: 1040pxbox already clears the OS controls. Now the inset is only applied when the centered box would actually slide under the window controls (narrow windows), keeping the logo aligned with the cards..session-loadinghad no CSS, so "Loading session…" rendered as bare text in the top-left and flashed away. Replaced with a full-viewport centered layout: a spinner (reusing the existingspinkeyframe), a muted label, and a gentle fade-in; the error fallback is styled too. Honorsprefers-reduced-motion.<a href="/">triggering a full document reload; under the cross-document view transition that reload could stall in the installed PWA, leaving the homepage stuck on "Loading sessions…". It now routes throughhandleNavClicklike the session cards, navigating client-side while still honoring modified clicks for open-in-new-tab.Test plan
make checkpasses.