implement values row syntax , first part (joins)#148
Merged
jongleb merged 2 commits intoygrek:ahrefsfrom Feb 3, 2025
Merged
Conversation
62c2aa4 to
e0e287e
Compare
Collaborator
Author
|
@ygrek Could you take a look , please |
Collaborator
Author
|
@ygrek I am merging it, If you have any comments, please write and I will fix them in the next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a support of
VALUES ROW(..)syntax.https://dev.mysql.com/doc/refman/8.4/en/values.html
At the current step, it's supported for
JOINS, but it's already now considered as a new source, so it wouldn't be a problem to support the rest of the usages of this syntax.Also it supports two variants of it:
And
And since
VALUESwith no ROWs afters is invalid syntax, I added a default expression when the passed list is empty:SELECT %cols% WHERE FALSEThis part is up for debate, but it seems safer