Use SO_REUSEADDR instead of SO_REUSEPORT as default#2409
Closed
angt wants to merge 1 commit intoyhirose:masterfrom
Closed
Use SO_REUSEADDR instead of SO_REUSEPORT as default#2409angt wants to merge 1 commit intoyhirose:masterfrom
angt wants to merge 1 commit intoyhirose:masterfrom
Conversation
SO_REUSEPORT should be opt-in rather than opt-out to prevent silent port sharing by default, only servers that intentionally want to share the same port should enable it. Signed-off-by: Adrien Gallouët <adrien@gallouet.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SO_REUSEPORT should be opt-in rather than opt-out to prevent silent port
sharing by default, only servers that intentionally want to share the
same port should enable it.
This is related to this issue: ggml-org/llama.cpp#20963.
This is a proposal. If not accepted we can override the socket options in llama.cpp instead.