Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 14, 2020

I need the compressed body.

@yhirose
Copy link
Owner

yhirose commented May 14, 2020

@vvanelslande, the change looks good to me except one place. Could you make sure the decompress_ is copied in copy_settings? Also could you add a simple unit test in test/test.cc?

void copy_settings(const Client &rhs) {

@yhirose
Copy link
Owner

yhirose commented May 15, 2020

@vvanelslande, it seems like this change breaks the unit test on GitHub Action... After you fix this failure and add a unit test for set_decompress , then I'll merge it right away. Thanks!

@ghost
Copy link
Author

ghost commented May 15, 2020

idk why it fails

@yhirose
Copy link
Owner

yhirose commented May 15, 2020

@vvanelslande, when you are still interested in the pull request, please fix the problem and add a simple unit test case as I always ask contributors. I'll close it for now until then. Thank you for your efforts!

@yhirose yhirose closed this May 15, 2020
yhirose added a commit that referenced this pull request May 26, 2020
ExclusiveOrange pushed a commit to ExclusiveOrange/cpp-httplib-exor that referenced this pull request May 2, 2023
SC-One pushed a commit to SC-One/cpp-httplib that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant