Prevent gdb exceptions when client closes socket prematurely #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@qt1, thanks for the pull request. After I reviewed your code, I came up another way to solve this issue and committed it. Could you try with it? You should be able to handle this issue with |
Contributor
Author
|
Yes, it does work. |
Contributor
|
@yhirose At the moment no optional definitions/flags are taken into account, and there are only Cmake options for using the dependencies and compilation. Did you want this to be an option for all the flags via Cmake? |
Owner
|
@sum01, you are right. I think we don't have to do anything for it for now. Thanks for your comment! |
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix #676
No signal is sent by OS if the client closes the connection prematurely so the http closes without stopping the program.