Return Server& from handler setters #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 21, 2021 17:05
ghost
marked this pull request as ready for review
|
@00ff0000red, thanks for the pull request. There is no problem to do the same with |
|
If I understood that corectly, you're okay with me adding a few more; on it! Do you think that the same should be done for other classes, like Client? |
added 2 commits
January 21, 2021 19:14
|
@00ff0000red, thanks for your fine contribution! |
ExclusiveOrange
pushed a commit
to ExclusiveOrange/cpp-httplib-exor
that referenced
this pull request
May 2, 2023
* Update httplib.h * Update httplib.h * Update httplib.h * Update httplib.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server instance methods,
set_error_handler,set_pre_routing_handler, andset_post_routing_handlerall returnedvoid.This updates them to return
Server&, allowing chaining between them.Is there anything else that might also make sense to chain?
I think
set_expect_100_continue_handler,set_logger,set_file_request_handler, and others should do the same.Suggestions?