Liquidity functions

[ultrasecreth]

• Small test improvements
• Implement maxFYTokenIn
• WIP maxFYTokenOut
• maxFYTokenOut working
• maxSharesIn working
• liquidity methods added to the Pool
• Add tests for liquidity methods at the pool level, fix bug on sellFYTokenPreview

[ultrasecreth]

Is this expected?, I've been thinking about it and it may be a problem for someone wanting to buy an exact amount

[devtooligan]

i went through the logic pretty deeply, i think it loos good.

some nit stuff on comments and a few questions to think about.

marco is gonna review the math as well.

i want to spend some time w the tests which i will do tomorrow but wanted to post these comments now

[devtooligan]

Let's remember to lint this right before it gets merged. I don't wanna lint it now because i'm afraid changes will get lost in the diff

[devtooligan]

Approving, but I'd still like to have a discussion around the methodology used with the "regular" pow function and explore whether:

a) It is appropriate to use that methodology in all edge cases
b) It can be used for the third max function

[ultrasecreth]

Let's remember to lint this right before it gets merged. I don't wanna lint it now because i'm afraid changes will get lost in the diff

yeah, I think I mentioned this somewhere I think, the linter in VSCode was changing so many things I decided not to, so the PR was clean.
I think there should be a different PR where not only the whole project is linted but also to commit the shared linting conf for the plugin and the .vscode to use it so everything is consistent in both IDE & command line for all devs

[ultrasecreth]

Approving, but I'd still like to have a discussion around the methodology used with the "regular" pow function and explore whether:

a) It is appropriate to use that methodology in all edge cases b) It can be used for the third max function

Should we schedule a zoom call?