Merged
Conversation
…l/yvarb into feat/notional-lever
|
Instead of a review, this time I chose to do some coding. It's a good sign, because it means that I'm finally comfortable with the code. In this branch, I fixed most of the imports and a warning, but more importantly I fixed approvals. We always do an ERC3156 flash loan, meaning that we always have to approve for the flash loan repayment. We get the In PR11 I made two deeper changes:
|
|
I didn't see exhaustive tests, so I would suggest that we start with those. There were bugs in there that would have wasted time from the frontend team. |
Introduce redeem
- While burning LP the base is returned to lever and not sent to the pool as we might have enough fyToken and do not require to purchase fyToken - The leftover fytoken is being sold to return base only to the user
alcueca
approved these changes
Nov 10, 2022
alcueca
left a comment
There was a problem hiding this comment.
Well done. Let's merge and see it live.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.