Merged
Conversation
alcueca
suggested changes
Nov 18, 2022
alcueca
left a comment
alcueca
left a comment
There was a problem hiding this comment.
Very good!
In general, let's try to make all these levers permissionless if we can. Less hassle.
Supporting ETH is going to add a good amount of code, but I think it is necessary.
alcueca
approved these changes
Nov 29, 2022
alcueca
left a comment
alcueca
left a comment
There was a problem hiding this comment.
The only really required changes are the one about the conditional, and pining the tests to a block. All others are about making the code and tests better, but are not compulsory.
Author
|
Merged with only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.