fix: enable rustls for imagod self-update GitHub client#395
Conversation
Co-authored-by: Codex <noreply@openai.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes imagod self-update failures in environments where the current ureq build lacks TLS support by enabling the rustls backend for HTTPS GitHub release queries.
Changes:
- Enable
ureq’srustlsfeature incrates/imagod. - Update
Cargo.lockto reflect the resulting TLS-related dependencies (rustls,rustls-pki-types,webpki-roots).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/imagod/Cargo.toml | Enables TLS for imagod’s ureq usage via the rustls feature. |
| Cargo.lock | Locks the updated dependency graph introduced by enabling ureq TLS support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 16233 uncovered lines. Files with missing lines (117)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 75.15% 75.15% —%
==========================================
Files 138 138 —
Lines 69554 69554 —
Branches 0 0 —
==========================================
+ Hits 53321 53321 —
- Misses 16233 16233 —
- Partials 0 0 —Generated by Codecov Action |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Motivation
Summary
ureq = { workspace = true, features = ["rustls"] }.Validation
cargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo test --workspace