Skip to content

fix: enable rustls for imagod self-update GitHub client#395

Merged
sizumita merged 1 commit intomainfrom
codex/fix-imagod-ureq-rustls
Mar 28, 2026
Merged

fix: enable rustls for imagod self-update GitHub client#395
sizumita merged 1 commit intomainfrom
codex/fix-imagod-ureq-rustls

Conversation

@sizumita
Copy link
Copy Markdown
Contributor

Motivation

  • imagod self update failed to query GitHub releases in environments where TLS transport was unavailable for the imagod ureq configuration.
  • This breaks update and tag-based update flows for users and increases operational risk.

Summary

  • Enabled Rustls for imagod's HTTP client by updating crates/imagod/Cargo.toml: ureq = { workspace = true, features = ["rustls"] }.
  • Kept other workspace dependency defaults unchanged.
  • Updated Cargo.lock for the resulting dependency graph.

Validation

  • cargo fmt --all
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace

Co-authored-by: Codex <noreply@openai.com>
Copilot AI review requested due to automatic review settings March 26, 2026 19:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes imagod self-update failures in environments where the current ureq build lacks TLS support by enabling the rustls backend for HTTPS GitHub release queries.

Changes:

  • Enable ureq’s rustls feature in crates/imagod.
  • Update Cargo.lock to reflect the resulting TLS-related dependencies (rustls, rustls-pki-types, webpki-roots).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
crates/imagod/Cargo.toml Enables TLS for imagod’s ureq usage via the rustls feature.
Cargo.lock Locks the updated dependency graph introduced by enabling ureq TLS support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 16233 uncovered lines.
✅ Project coverage is 75.15%. Comparing base (base) to head (head).

Files with missing lines (117)
File Patch % Lines
lib.rs 38.44% ⚠️ 1635 Missing
lib.rs 38.42% ⚠️ 1223 Missing
lib.rs 42.98% ⚠️ 1147 Missing
mod.rs 67.84% ⚠️ 1046 Missing
plugin_resolver.rs 41.93% ⚠️ 955 Missing
plugin_sources.rs 71.82% ⚠️ 858 Missing
router.rs 27.82% ⚠️ 556 Missing
service_supervisor.rs 85.40% ⚠️ 418 Missing
mod.rs 89.05% ⚠️ 397 Missing
orchestrator.rs 81.41% ⚠️ 365 Missing
main.rs 0.00% ⚠️ 357 Missing
session_loop.rs 65.05% ⚠️ 346 Missing
rpc_values.rs 12.01% ⚠️ 301 Missing
manager_runtime.rs 25.14% ⚠️ 261 Missing
runner_process.rs 48.06% ⚠️ 257 Missing
logs_forwarder.rs 77.16% ⚠️ 255 Missing
remote_rpc.rs 70.58% ⚠️ 248 Missing
lib.rs 52.85% ⚠️ 225 Missing
resources.rs 85.87% ⚠️ 215 Missing
certs.rs 59.75% ⚠️ 214 Missing
lib.rs 85.65% ⚠️ 205 Missing
mod.rs 81.31% ⚠️ 190 Missing
http_supervisor.rs 26.67% ⚠️ 186 Missing
mod.rs 69.82% ⚠️ 180 Missing
runtime_entry.rs 87.21% ⚠️ 167 Missing
self_update.rs 73.96% ⚠️ 148 Missing
plugin_cache.rs 50.29% ⚠️ 147 Missing
init.rs 80.78% ⚠️ 141 Missing
ui.rs 75.72% ⚠️ 134 Missing
manager_control.rs 85.89% ⚠️ 131 Missing
lib.rs 78.02% ⚠️ 130 Missing
rpc_bridge.rs 60.61% ⚠️ 122 Missing
mod.rs 86.06% ⚠️ 121 Missing
run.rs 36.98% ⚠️ 115 Missing
artifact_store.rs 90.63% ⚠️ 107 Missing
lib.rs 84.23% ⚠️ 101 Missing
lib.rs 77.35% ⚠️ 101 Missing
lib.rs 0.00% ⚠️ 96 Missing
ps.rs 55.20% ⚠️ 94 Missing
lib.rs 85.24% ⚠️ 94 Missing
mod.rs 97.57% ⚠️ 93 Missing
protocol_handler.rs 69.63% ⚠️ 90 Missing
command_common.rs 59.31% ⚠️ 86 Missing
dbus_p2p.rs 70.66% ⚠️ 86 Missing
config.rs 69.51% ⚠️ 86 Missing
workspace.rs 57.62% ⚠️ 86 Missing
service.rs 86.23% ⚠️ 83 Missing
stop.rs 43.06% ⚠️ 78 Missing
retained_file_store.rs 79.72% ⚠️ 76 Missing
packages.rs 74.16% ⚠️ 75 Missing
lib.rs 69.47% ⚠️ 73 Missing
manifest.rs 76.55% ⚠️ 71 Missing
hydrate.rs 89.92% ⚠️ 70 Missing
model.rs 72.80% ⚠️ 68 Missing
launch_builder.rs 81.82% ⚠️ 62 Missing
planner.rs 93.70% ⚠️ 60 Missing
io.rs 77.27% ⚠️ 58 Missing
lib.rs 89.83% ⚠️ 54 Missing
dependency.rs 85.82% ⚠️ 53 Missing
tls_material.rs 84.36% ⚠️ 48 Missing
validation.rs 82.90% ⚠️ 44 Missing
git.rs 75.00% ⚠️ 43 Missing
graph.rs 0.00% ⚠️ 43 Missing
apply.rs 92.93% ⚠️ 34 Missing
lock_resolution.rs 86.77% ⚠️ 28 Missing
lib.rs 79.29% ⚠️ 27 Missing
manifest_hash.rs 84.33% ⚠️ 25 Missing
envelope_io.rs 92.63% ⚠️ 25 Missing
explain.rs 0.00% ⚠️ 25 Missing
runner_spawn.rs 68.67% ⚠️ 23 Missing
registry.rs 81.15% ⚠️ 23 Missing
capability_checker.rs 90.32% ⚠️ 21 Missing
binding.rs 88.46% ⚠️ 20 Missing
mod.rs 90.60% ⚠️ 20 Missing
expand.rs 73.81% ⚠️ 18 Missing
shutdown.rs 77.11% ⚠️ 18 Missing
cache_refresh.rs 87.06% ⚠️ 17 Missing
validation.rs 89.22% ⚠️ 17 Missing
runtime.rs 90.74% ⚠️ 16 Missing
operation_state.rs 91.89% ⚠️ 16 Missing
log_buffer.rs 95.50% ⚠️ 16 Missing
error_diagnostics.rs 94.01% ⚠️ 15 Missing
descriptor.rs 93.60% ⚠️ 15 Missing
validation.rs 93.84% ⚠️ 15 Missing
cache.rs 86.92% ⚠️ 14 Missing
dependency.rs 93.33% ⚠️ 14 Missing
commit.rs 83.67% ⚠️ 14 Missing
lib.rs 70.21% ⚠️ 14 Missing
hash.rs 85.43% ⚠️ 13 Missing
command.rs 92.66% ⚠️ 13 Missing
lib.rs 0.00% ⚠️ 13 Missing
wasi_nn.rs 65.91% ⚠️ 12 Missing
resolver.rs 95.72% ⚠️ 12 Missing
lib.rs 88.00% ⚠️ 11 Missing
capabilities.rs 89.86% ⚠️ 9 Missing
digest.rs 89.31% ⚠️ 8 Missing
artifact.rs 94.97% ⚠️ 8 Missing
main.rs 0.00% ⚠️ 7 Missing
runner_runtime.rs 0.00% ⚠️ 7 Missing
requested.rs 97.44% ⚠️ 6 Missing
envelope.rs 83.78% ⚠️ 6 Missing
main.rs 0.00% ⚠️ 6 Missing
target.rs 89.87% ⚠️ 5 Missing
network.rs 94.20% ⚠️ 4 Missing
args.rs 85.37% ⚠️ 4 Missing
session_index.rs 97.35% ⚠️ 4 Missing
quic_builder.rs 91.30% ⚠️ 4 Missing
validation.rs 96.30% ⚠️ 3 Missing
codec.rs 95.50% ⚠️ 3 Missing
expectation.rs 96.64% ⚠️ 2 Missing
server_builder.rs 97.37% ⚠️ 2 Missing
lib.rs 85.71% ⚠️ 1 Missing
cbor.rs 92.31% ⚠️ 1 Missing
hello.rs 98.41% ⚠️ 1 Missing
log.rs 95.65% ⚠️ 1 Missing
rpc.rs 98.84% ⚠️ 1 Missing
service.rs 96.67% ⚠️ 1 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    75.15%    75.15%        —%
==========================================
  Files          138       138         —
  Lines        69554     69554         —
  Branches         0         0         —
==========================================
+ Hits         53321     53321         —
- Misses       16233     16233         —
- Partials         0         0         —

Generated by Codecov Action

@sizumita
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sizumita sizumita merged commit 6d26662 into main Mar 28, 2026
27 checks passed
@sizumita sizumita deleted the codex/fix-imagod-ureq-rustls branch March 28, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants