CASSANDRA-20938 CQLSSTableWriter with dict compression #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiklosovic
force-pushed
the
CASSANDRA-20938
branch
from
f7f6100 to
2f58128
Compare
smiklosovic
force-pushed
the
CASSANDRA-20938
branch
from
2f58128 to
64c4177
Compare
smiklosovic
commented
Oct 20, 2025
|
|
||
| SSTable.Owner useOwner; | ||
|
|
||
| if (this.owner != null && this.owner.compressionDictionaryManager() != null && compressionDictionary != null) |
Author
There was a problem hiding this comment.
CQLSSTableWriter uses such a flow that owner passed to this method is null. Then compression manager will be null (logic in SSTableTxnWriter.create) and we do not want that.
So when compression dictionary is set from outside, we need cfs as owner of that as well so we pass that owner to create method instead.
smiklosovic
commented
Oct 20, 2025
| } | ||
|
|
||
| IDictionaryCompressor compressor = (IDictionaryCompressor) compressionParams.getSstableCompressor(); | ||
| if (!compressor.canConsumeDictionary(compressionDictionary)) |
Author
There was a problem hiding this comment.
I can not actually test this one because the check in that method is based on kinds and there is just one ... it is an enum. There is nothing else to set but that. We do not have two dictionary compressors of two different kinds yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.