Merged
Conversation
Add a demo for estimate pi
Fixed the issue where the circle was flattened due to the title
Collaborator
|
Hi @yihui, I guess you might be on summer holiday, but may I ask, should we approve this merge? |
Contributor
Author
|
Hi @yulijia, It's a good idea to add the information "the number of points inside the circle". I have added relevant information to the output message, but I haven't added such information to the animation for the time being because there isn't enough space. Thank you for your suggestions for improvement! |
Contributor
Author
|
@yulijia 麻烦您再看看修改后的效果是否合意？如有不妥之处，不吝赐教，我继续完善。 |
yihui
reviewed
Aug 26, 2025
pi_est -> pi_hat
chuxinyuan
commented
Aug 26, 2025
yihui
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new demo for estimate pi