test: Add method to verify children order in tree traversal with disordered XML data.
#37
Conversation
…rdered `XML` data.
WalkthroughA new test method was added to the Changes
Sequence Diagram(s)sequenceDiagram
participant TestCase
participant Database
participant TreeModel
TestCase->>Database: Initialize and load test-disorder.xml
TestCase->>Database: Insert tree nodes (root and children)
TestCase->>TreeModel: Retrieve root node (ID 1)
TestCase->>TreeModel: Call children() on root node
TreeModel->>Database: Query for children ORDER BY lft
Database-->>TreeModel: Return children sorted by lft
TreeModel-->>TestCase: Return ordered children
TestCase->>TestCase: Assert children count and order
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 phpcs (3.7.2)tests/NestedSetsBehaviorTest.php📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🪛 PHPMD (2.15.0)tests/NestedSetsBehaviorTest.php2303-2303: Avoid using static access to class '\yii2\extensions\nestedsets\tests\support\model\Tree' in method 'testChildrenMethodRequiresOrderByForCorrectTreeTraversal'. (Clean Code Rules) (StaticAccess) ⏰ Context from checks skipped due to timeout of 90000ms (9)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 90 90
===========================================
Files 2 2
Lines 469 469
===========================================
Hits 469 469 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Adds a new XML fixture and test to verify that child nodes are returned in the correct lft order when input data is disordered.
- Introduces
test-disorder.xmlwith intentionally shuffledlftvalues. - Adds
testChildrenMethodRequiresOrderByForCorrectTreeTraversalto the test suite.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/support/data/test-disorder.xml | New XML fixture containing disordered <tree> elements |
| tests/NestedSetsBehaviorTest.php | New test method inserting nodes from the fixture and asserting order |
Comments suppressed due to low confidence (2)
tests/NestedSetsBehaviorTest.php:2289
- The
$elementkey inforeachoverSimpleXMLElement->children()will be numeric, not the tag name, so the conditionif ($element === 'tree')never passes. Consider iterating directly withforeach ($children->tree as $treeElement)or checking$treeElement->getName() === 'tree'.
foreach ($children as $element => $treeElement) {
tests/NestedSetsBehaviorTest.php:2310
- To ensure the test enforces ordering, chain an explicit
orderBy(['lft' => SORT_ASC])before->all(), e.g.$root->children()->orderBy(['lft' => SORT_ASC])->all().
$childrenList = $root->children()->all();
1 participant
Summary by CodeRabbit