test: Add verification for correct order of root nodes in MultipleTree traversal.
#38
Conversation
WalkthroughThe changes refactor a test for nested set tree traversal by removing reliance on XML fixtures and direct database inserts, instead creating nodes programmatically and manipulating their ordering attributes. A new test is added for root node ordering in a multiple tree scenario. An obsolete XML test dataset is deleted. Changes
Sequence Diagram(s)sequenceDiagram
participant Test as Test Method
participant DB as Database
participant Tree as Tree Model
Test->>DB: Initialize empty database
Test->>Tree: Create root node
Test->>Tree: Create child nodes (A, B, C)
Test->>Tree: Append children to root
Test->>DB: Manually update lft/rgt values to disorder children
Test->>Tree: Retrieve children with children() method
Test->>Test: Assert correct order and types
sequenceDiagram
participant Test as Test Method
participant DB as Database
participant MultipleTree as MultipleTree Model
Test->>DB: Initialize empty database
Test->>MultipleTree: Create root nodes (D, B, A, C)
Test->>MultipleTree: Retrieve roots with roots() method
Test->>Test: Assert correct order, count, and types
Possibly related PRs
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 phpcs (3.7.2)tests/NestedSetsBehaviorTest.php📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 90 90
===========================================
Files 2 2
Lines 469 469
===========================================
Hits 469 469 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…r in `NestedSetsBehavior`.
There was a problem hiding this comment.
Pull Request Overview
This PR replaces XML-based fixtures with programmatic tree setup and adds tests to ensure correct root and child node ordering in MultipleTree/Tree traversals.
- Deleted an obsolete XML dataset used for testing node order.
- Added a new test for verifying root-node order in
NestedSetsQueryBehaviorTest. - Refactored the child-order test in
NestedSetsBehaviorTestto useappendToand manual lft/rgt updates.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/support/data/test-disorder.xml | Removed obsolete XML fixture for node ordering tests. |
| tests/NestedSetsQueryBehaviorTest.php | Added new test to verify ordering of root nodes in tree traversal. |
| tests/NestedSetsBehaviorTest.php | Refactored child-order test to programmatically create and reorder nodes. |
1 participant
Summary by CodeRabbit