test(http): Refactor memory threshold tests in StatelessApplicationProvider and update ApplicationMemoryTest class for improved validation scenarios.

[terabytesoftw]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌

Summary by CodeRabbit

• Tests

  • Replaced several specialized memory-threshold tests with a single data-driven suite covering multiple memory-limit scenarios, including edge cases.
  • Added a reusable provider delivering varied memory-limit inputs and expected outcomes.
  • Kept tests verifying unlimited-memory handling and output-clearing behavior; minor test documentation/comments refined.

• Chores

  • No user-facing changes; improves test reliability and maintainability.

[coderabbitai]

Walkthrough

Consolidates three specialized memory-threshold tests into a single data-driven test using a new provider method, annotates an existing positive-limit test with a data provider and docblock, and adds the memoryThreshold() provider returning multiple scenarios.

Changes

Cohort / File(s)	Summary
Stateless HTTP application memory tests tests/http/stateless/ApplicationMemoryTest.php	Replaced three specific threshold tests with testCleanBehaviorWithDifferentMemoryLimits(string $memoryLimit, bool $shouldTriggerSpecialTest, string $assertionMessage) annotated with #[DataProviderExternal(StatelessApplicationProvider::class, 'memoryThreshold')]. Annotated testSetMemoryLimitWithPositiveValueSetsLimitDirectly(...) with #[DataProviderExternal(StatelessApplicationProvider::class, 'memoryLimitPositive')] and added a docblock; preserved other minor tests and a small comment tweak.
Test data providers tests/provider/StatelessApplicationProvider.php	Added public static function memoryThreshold(): array returning named scenarios (memory limit, expected boolean, message) covering multiple memory-limit cases including a high (2G) scenario that triggers special behavior.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor PHPUnit as PHPUnit
  participant Provider as StatelessApplicationProvider
  participant Test as ApplicationMemoryTest
  participant App as StatelessApplication

  PHPUnit->>Provider: memoryThreshold()
  Provider-->>PHPUnit: scenarios [memoryLimit, shouldTriggerSpecialTest, message]
  loop for each scenario
    PHPUnit->>Test: testCleanBehaviorWithDifferentMemoryLimits(limit, flag, message)
    Test->>App: ini_set('memory_limit', limit) / setMemoryLimit(limit)
    alt flag == false
      Test->>App: call clean()
      App-->>Test: return false
      Test-->>PHPUnit: assert false with message
    else flag == true
      Test->>App: compute artificial threshold from current usage
      Test->>App: setMemoryLimit(artificialThreshold)
      Test->>App: call clean()
      App-->>Test: return true
      Test-->>PHPUnit: assert true with message
    end
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• test(http): Extract memory tests from ApplicationTest to ApplicationMemoryTest class. #117 — Refactors/consolidates memory-related tests in ApplicationMemoryTest.php, directly overlapping the same test methods and replacements.
• test(http): Add data provider for memoryLimitPositive tests in StatelessApplicationProvider and refactor related tests in ApplicationMemoryTest class. #127 — Introduces data-provider usage and modifications to the same test/provider files, aligning closely with this change.
• test(StatelessApplicationTest): Add test for correct memory threshold calculation at '90%' limit. #47 — Previously added the 90% threshold and exact-equal cases that this PR consolidates into a data-driven scenario.

Poem

I nibble bytes and count the hops,
One test now sorts the memory props.
Providers sing each case in line,
Thresholds neat, assertions fine.
A rabbit cheers — tests pass on time! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bce768e and c08fb57.

📒 Files selected for processing (2)

• tests/http/stateless/ApplicationMemoryTest.php (3 hunks)
• tests/provider/StatelessApplicationProvider.php (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• tests/provider/StatelessApplicationProvider.php
• tests/http/stateless/ApplicationMemoryTest.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: phpunit / PHP 8.1-windows-latest
• GitHub Check: mutation / PHP 8.3-ubuntu-latest
• GitHub Check: mutation / PHP 8.3-ubuntu-latest

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-mini-110

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6fc78d3) to head (c08fb57).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##                main      #129   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       318       318           
===========================================
  Files             12        12           
  Lines            808       808           
===========================================
  Hits             808       808           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

tests/provider/StatelessApplicationProvider.php (1)

228-255: Clarify the 2G scenario message and align it with the expected outcome

Great addition. Small nit: the dataset message for the '2G' case doesn’t state the expected result, while the test asserts true. Make the message explicit to improve failure diagnostics.

Apply this diff to clarify the message:

-            'high memory setup - 2G' => [
+            'high memory setup - 2G' => [
                 '2G',
                 true,
-                "Memory configuration with '2G' for exact threshold testing.",
+                "'clean()' should return 'true' when memory usage equals the calculated '90%' threshold (using adjusted limit).",
             ],

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6fc78d3 and bce768e.

📒 Files selected for processing (2)

• tests/http/stateless/ApplicationMemoryTest.php (3 hunks)
• tests/provider/StatelessApplicationProvider.php (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

tests/http/stateless/ApplicationMemoryTest.php (4)

tests/provider/StatelessApplicationProvider.php (1)

• StatelessApplicationProvider (11-256)

tests/TestCase.php (1)

• statelessApplication (134-197)

src/http/StatelessApplication.php (3)

• handle (269-295)
• clean (141-152)
• setMemoryLimit (326-335)

tests/support/FactoryHelper.php (2)

• FactoryHelper (46-268)
• createServerRequestCreator (154-161)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: phpunit / PHP 8.3-ubuntu-latest
• GitHub Check: mutation / PHP 8.3-ubuntu-latest
• GitHub Check: mutation / PHP 8.3-ubuntu-latest

🔇 Additional comments (3)

tests/http/stateless/ApplicationMemoryTest.php (3)

33-38: Good consolidation into a data-driven test

Switching to a single provider-driven test improves readability and reduces duplication across threshold scenarios. Looks good.

---

247-247: No action needed

Minor comment wording tweak only; nothing to change.

---

265-267: Docblock addition is appropriate

Adding the throws annotation improves clarity without changing behavior.