fix(tests): Add test for memory usage at 90% threshold in ApplicationMemoryTest class.
#195
Conversation
…ionMemoryTest` class.
WalkthroughUpdated changelog text and refined stateless application memory tests: adjusted a data provider and test signature, removed a boolean expectation, and added a boundary test that asserts Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant T as Test
participant A as StatelessApplication
participant M as MemoryInspector
note right of T `#DDEBF7`: setup & execute request
T->>A: execute request
A->>M: getCurrentMemoryUsage()
M-->>A: currentUsage
note right of A `#F7F6D9`: compute limit = currentUsage / 0.9
T->>A: setMemoryLimit(limit)
T->>A: call clean()
A->>M: measure usage inside clean()
M-->>A: usage
alt usage <= threshold
A-->>T: clean() returns true
else usage > threshold
A-->>T: clean() returns false
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–25 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 362 362
===========================================
Files 13 13
Lines 867 867
===========================================
Hits 867 867 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/http/stateless/ApplicationMemoryTest.php (1)
78-97: Good boundary test addition for clarity.The test correctly verifies that
clean()returnstruewhen memory usage is exactly at the 90% threshold. The math is sound: settinglimit = currentUsage / 0.9ensures thatbound = limit * 0.9 = currentUsage, creating the exact boundary condition.Note that similar logic exists in
testCleanBehaviorWithDifferentMemoryLimits(lines 65-73), but having this as a dedicated test improves clarity and makes the boundary condition more explicit and easier to understand.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)tests/http/stateless/ApplicationMemoryTest.php(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: terabytesoftw
Repo: yii2-extensions/psr-bridge PR: 180
File: composer.json:64-65
Timestamp: 2025-09-28T11:51:01.274Z
Learning: In the yii2-extensions/psr-bridge project, terabytesoftw prefers removing the `--only-covered` flag from infection mutation testing commands to run mutation testing on all code rather than just covered code paths.
🧬 Code graph analysis (1)
tests/http/stateless/ApplicationMemoryTest.php (3)
tests/support/TestCase.php (1)
statelessApplication(160-220)src/http/StatelessApplication.php (2)
setMemoryLimit(326-335)clean(141-152)tests/support/FactoryHelper.php (2)
FactoryHelper(46-268)createServerRequestCreator(154-161)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: phpunit / PHP 8.1-ubuntu-latest
- GitHub Check: phpunit / PHP 8.2-windows-2022
- GitHub Check: phpunit / PHP 8.4-windows-2022
- GitHub Check: phpunit / PHP 8.4-ubuntu-latest
- GitHub Check: phpunit / PHP 8.3-ubuntu-latest
- GitHub Check: phpunit / PHP 8.2-ubuntu-latest
- GitHub Check: phpunit-dev / PHP 8.6-ubuntu-latest
- GitHub Check: phpunit-dev / PHP 8.5-ubuntu-latest
- GitHub Check: phpstan / PHP 8.4-ubuntu-latest
- GitHub Check: mutation / PHP 8.3-ubuntu-latest
- GitHub Check: linter / Super Linter
- GitHub Check: mutation / PHP 8.3-ubuntu-latest
- GitHub Check: linter / Super Linter
Summary by CodeRabbit
Tests
Chores