Skip to content

[bugfix] Fixed can not save bug when model's primary key is multiple. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
disem merged 1 commit into from
Dec 16, 2015
Merged

[bugfix] Fixed can not save bug when model's primary key is multiple. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions EditableAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public function run()
$class = $this->modelClass;
$pk = Yii::$app->request->post('pk');
$attribute = Yii::$app->request->post('name');
//For attributes with format - relationName.attributeName
//For attributes with format - relationName.attributeName
if (strpos($attribute, '.')) {
$attributeParts = explode('.', $attribute);
$attribute = array_pop($attributeParts);
Expand All @@ -69,7 +69,7 @@ public function run()
throw new BadRequestHttpException("Value cannot be empty.");
}
/** @var \Yii\db\ActiveRecord $model */
$model = $class::findOne([$this->pkColumn => $pk]);
$model = $class::findOne(is_array($pk) ? $pk : [$this->pkColumn => $pk]);
if (!$model) {
if ($this->forceCreate) { // only useful for models with one editable attribute or no validations
$model = new $class;
Expand All @@ -93,4 +93,4 @@ public function run()
}
}

}
}