Skip to content

Allow BC check to install dev dependencies#128

Merged
samdark merged 2 commits into
masterfrom
bc-install-development-dependencies
May 30, 2026
Merged

Allow BC check to install dev dependencies#128
samdark merged 2 commits into
masterfrom
bc-install-development-dependencies

Conversation

@samdark
Copy link
Copy Markdown
Member

@samdark samdark commented May 30, 2026

Adds an optional install-development-dependencies input to the reusable BC workflow.\n\nWhen enabled, the workflow passes --install-development-dependencies to roave/backward-compatibility-check. This lets consumers compare packages whose released API references symbols from development dependencies, while keeping the current default behavior unchanged.\n\nNeeded by yiisoft/validator#797, where Roave otherwise reports skipped debug collector symbols from the compared release.

Copilot AI review requested due to automatic review settings May 30, 2026 13:38
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c87c491a-e7ae-4675-ad34-46179ae80a83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bc-install-development-dependencies

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the reusable backward-compatibility (BC) workflow by adding an optional input to allow installing development dependencies when running roave/backward-compatibility-check, enabling accurate comparisons for packages whose public API references symbols from dev dependencies.

Changes:

  • Added a new install-development-dependencies boolean input to the reusable workflow.
  • Updated the BC check command to conditionally pass --install-development-dependencies based on the new input.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/bc.yml Outdated
@samdark samdark merged commit c589fb1 into master May 30, 2026
3 checks passed
@samdark samdark deleted the bc-install-development-dependencies branch May 30, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants