Skip to content

Put test log to the runtime directory in example #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samdark merged 1 commit into from
Jun 5, 2020
Merged

Put test log to the runtime directory in example #4

samdark merged 1 commit into from
Jun 5, 2020

Conversation

@viktorprogger
Copy link
Contributor

@viktorprogger viktorprogger commented Jun 5, 2020

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Tests pass? ✔️
Fixed issues ❌

@viktorprogger viktorprogger requested review from a team and terabytesoftw June 5, 2020 09:08
terabytesoftw
terabytesoftw approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@terabytesoftw terabytesoftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Jun 5, 2020
@samdark samdark merged commit 4747b4a into master Jun 5, 2020
@samdark samdark deleted the readme-log-directory branch June 5, 2020 09:57
@wiperawa wiperawa mentioned this pull request Jul 3, 2020
Closed
@fufudao fufudao mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terabytesoftw terabytesoftw terabytesoftw approved these changes

Assignees

No one assigned

Labels

status:code review The pull request needs review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@viktorprogger @terabytesoftw @samdark