Skip to content

Improve work with float keys + more tests #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samdark merged 8 commits into from
Oct 16, 2020
Merged

Improve work with float keys + more tests #59

samdark merged 8 commits into from
Oct 16, 2020

Conversation

@vjik
Copy link
Member

@vjik vjik commented Oct 11, 2020 •
edited
Loading

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues #58

Tests in PHP 8 should be pass after release yiisoft/strings with yiisoft/strings#43

@vjik vjik requested a review from a team October 11, 2020 12:54
@vjik vjik added the status:code review The pull request needs review. label Oct 11, 2020
rustamwin
rustamwin reviewed Oct 15, 2020
View reviewed changes
@samdark samdark merged commit 3fad714 into yiisoft:master Oct 16, 2020
@vjik vjik deleted the enh branch October 16, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rustamwin rustamwin rustamwin left review comments

@samdark samdark samdark approved these changes

Assignees

No one assigned

Labels

status:code review The pull request needs review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vjik @samdark @rustamwin