Skip to content

Move filter handler check to QueryDataReader + Tests #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vjik merged 6 commits into from
Aug 25, 2025
Merged

Move filter handler check to QueryDataReader + Tests #102

vjik merged 6 commits into from
Aug 25, 2025

Conversation

@vjik
Copy link
Member

@vjik vjik commented Aug 24, 2025

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ✔️

@vjik vjik requested a review from a team August 24, 2025 19:08
@vjik vjik added the status:code review The pull request needs review. label Aug 24, 2025
Tigrov
Tigrov approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@Tigrov Tigrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different style of calling assertions

https://github.com/yiisoft/data-db/pull/102/files#diff-99c587d842b906654bd4134a0a90ebcca6f209fb8b866c9d337919d69c43e03dR27-R29

https://github.com/yiisoft/data-db/pull/102/files#diff-8f0e26a92cc2e647be3607d0ff0410e5079a3f53694f7996f95024b653664108R24-R25

@vjik vjik merged commit 0d8c2a4 into master Aug 25, 2025
73 of 74 checks passed
@vjik vjik deleted the refactor branch August 25, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tigrov Tigrov Tigrov approved these changes

Assignees

No one assigned

Labels

status:code review The pull request needs review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vjik @Tigrov @StyleCIBot