Skip to content

Conversation

@vjik
Copy link
Member

@vjik vjik commented Sep 4, 2025

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️

@vjik vjik requested a review from a team September 4, 2025 17:20
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 84.74576% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.61%. Comparing base (d1d7ef3) to head (a353320).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/FilterHandler/EqualsExpressionHandler.php 0.00% 4 Missing ⚠️
src/QueryDataReader.php 89.18% 4 Missing ⚠️
src/FilterHandler.php 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d1d7ef3) and HEAD (a353320). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d1d7ef3) HEAD (a353320)
6 5
Additional details and impacted files
@@              Coverage Diff               @@
##              master     #110       +/-   ##
==============================================
- Coverage     100.00%   76.61%   -23.39%     
- Complexity        90       98        +8     
==============================================
  Files             21       22        +1     
  Lines            271      295       +24     
==============================================
- Hits             271      226       -45     
- Misses             0       69       +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik added the status:code review The pull request needs review. label Sep 4, 2025
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Need docs.

@samdark samdark added the type:feature New feature label Sep 4, 2025

public function map(string $field): string|ExpressionInterface
{
return $this->map[$field] ?? $field;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it return new ColumnName() if the value is string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, no. Yii DB quote string values

Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
@vjik vjik merged commit 4a9b827 into master Sep 5, 2025
73 of 74 checks passed
@vjik vjik deleted the field-mapper branch September 5, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review. type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants