Skip to content

Revert transactional migration when adding migration to history fails#289

Merged
Tigrov merged 5 commits intomasterfrom
migration-and-history-record
Mar 14, 2025
Merged

Revert transactional migration when adding migration to history fails#289
Tigrov merged 5 commits intomasterfrom
migration-and-history-record

Conversation

@Tigrov
Copy link
Copy Markdown
Member

@Tigrov Tigrov commented Mar 12, 2025

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #284

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.09%. Comparing base (e15de0b) to head (b8b4ed8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Migrator.php 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
+ Coverage     96.08%   96.09%   +0.01%     
- Complexity      312      314       +2     
============================================
  Files            21       21              
  Lines          1046     1050       +4     
============================================
+ Hits           1005     1009       +4     
  Misses           41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tigrov Tigrov added the status:code review The pull request needs review. label Mar 12, 2025
@Tigrov Tigrov requested a review from a team March 12, 2025 09:18
Comment thread src/Migrator.php Outdated
Comment thread src/Migrator.php Outdated
@Tigrov Tigrov merged commit 88e0bab into master Mar 14, 2025
36 of 38 checks passed
@Tigrov Tigrov deleted the migration-and-history-record branch March 14, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants