Skip to content

Conversation

@vjik
Copy link
Member

@vjik vjik commented Nov 26, 2025

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️

Related to yiisoft/db#1107

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.73%. Comparing base (3d67a71) to head (c973627).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #448      +/-   ##
============================================
+ Coverage     98.70%   98.73%   +0.02%     
- Complexity      252      259       +7     
============================================
  Files            24       24              
  Lines           775      791      +16     
============================================
+ Hits            765      781      +16     
  Misses           10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik mentioned this pull request Nov 26, 2025
@vjik vjik marked this pull request as ready for review November 29, 2025 10:28
@vjik vjik requested review from a team and Tigrov November 29, 2025 10:28
@vjik vjik added the status:code review The pull request needs review. label Nov 29, 2025
@vjik vjik requested a review from Copilot November 29, 2025 11:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds native MySQL ENUM column type support by introducing the EnumColumn class and implementing the necessary building logic for column definitions.

Key Changes:

  • Migrates enum_col test data from StringColumn to EnumColumn with the new values property
  • Implements buildType() method support for generating ENUM(...) column definitions
  • Adds buildCheck() method override to prevent redundant CHECK constraints on native ENUM columns
  • Adds comprehensive test coverage for enum column functionality

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/Provider/SchemaProvider.php Updates test data to use EnumColumn instead of StringColumn for enum columns with new values property
tests/Column/EnumColumnTest.php Adds MySQL-specific tests for enum column parsing, including negative tests for non-enum CHECK constraints
tests/Column/ColumnDefinitionBuilderTest.php Adds unit tests for building enum column definitions, including case-sensitivity handling
src/Column/ColumnDefinitionBuilder.php Implements enum type building logic and CHECK constraint suppression for native MySQL ENUM types
CHANGELOG.md Documents the new enumeration column type support feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vjik vjik merged commit 8289d09 into master Nov 30, 2025
36 checks passed
@vjik vjik deleted the enum-col branch November 30, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants