Enhacement DatabaseFactory for master and slave.

[terabytesoftw]

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	❌
Tests pass?	✔️

• Create DatabaseFactory independent, will allow to create the master and slave connections through the factory with autowired.

Example:

$connection->masters[] = [
    'setDsn()'      => ['mysql:host=127.0.0.1;dbname=yiitest'],
    'setUsername()' => ['root],
    'setPassword()' => ['root'],
];

$connection->open();

• Remove dsn from the constructor: The dsn of the constructor was removed and two setters were created for its configuration.

Example Array:

$db = new Connection($cache, $logger, $profiler);

$dsn => [
     'driver' => 'mysql',
     'host'   => '127.0.0.1',
     'dbname' => 'yiitest',
],

$db->setBuildDsn($dsn);

Example string:

$db = new Connection($cache, $logger, $profiler);

$db->setDsn('mysql:host=127.0.0.1;dbname=yiitest');

• Change name badged README.md phpunit --> build.

[xepozz]

I don't like it. Let's avoid lazy initializing via $config = [...].
I think it can be developed with ReplicationConnectionInterface (or smth else), that will have methods addMaster(ConnectionInterface $connection), addSlave(ConnectionInterface $connection) and other.

[terabytesoftw]

I don't like it. Let's avoid lazy initializing via $config = [...].
I think it can be developed with ReplicationConnectionInterface (or smth else), that will have methods addMaster(ConnectionInterface $connection), addSlave(ConnectionInterface $connection) and other.

In this particular case the factory avoids two things, one injecting the dependencies, and two possibility of creating dynamic connections, if I define everything in the container di that cannot be done.

[samdark]

Is connection possible without DSN?

[terabytesoftw]

Is connection possible without DSN?

You can create the Connection::class without configuring Dsn, Username and Password, but when you are going to open connection $connection->open() , if it is not configured, throw an exception, example:

db/src/Drivers/Connection.php

Line 689 in aad933b

if (empty($this->dsn)) {

The idea for now is to clean the constructor as much as possible, in order to inject the interfaces of SchemaInterface and CommandInterface and eliminate the factory within Connection::class.

Creating the connection class does not mean that you create the instance of PDO::class, it only creates at the time of opening the connection.

Having a DSN setter also allows you to have a connection created and to be able to access any connection dynamically, that is also an advantage.

I would have no problem adding more tests where we checked the exception without configuration of Dsn, Username and Password.

[samdark]

If we can't use Connection without DSN, it's better to have it as a mandatory requirement i.e. keep it in constructor.

[terabytesoftw]

If we can't use Connection without DSN, it's better to have it as a mandatory requirement i.e. keep it in constructor.

Its mandatory for PDO::class not for Connection::class, which does too many things, and these changes are to decouple that class.

[samdark]

Thanks!