Skip to content

Improve command class. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samdark merged 1 commit into from
Mar 3, 2020
Merged

Improve command class. #116

samdark merged 1 commit into from
Mar 3, 2020

Conversation

@terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Mar 3, 2020

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
Tests pass? ✔️
  • add getters and setters.
  • move phpdoc property private to setters and getters.
  • change visibility property public to private.
  • fixed tests.

@terabytesoftw terabytesoftw requested review from a team and samdark March 3, 2020 13:30
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Mar 3, 2020
@samdark samdark merged commit c30c6ff into yiisoft:master Mar 3, 2020
@terabytesoftw terabytesoftw deleted the improve-command branch March 4, 2020 10:20
@terabytesoftw terabytesoftw removed the status:code review The pull request needs review. label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samdark samdark Awaiting requested review from samdark

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terabytesoftw @samdark