Refactoring and cleanup #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdark
reviewed
Aug 31, 2020
| * available and `$fallbackToMaster` is false. This property is read-only. | ||
| * @property PDO $slavePdo The PDO instance for the currently active slave connection. `null` is returned if no slave | ||
| * connection is available and `$fallbackToMaster` is false. This property is read-only. | ||
| * @property Transaction|null $transaction The currently active transaction. Null if no active transaction. This |
Member
There was a problem hiding this comment.
@property annotations seem become obsolete and could be deleted.
| use Yiisoft\Db\Exception\InvalidConfigException; | ||
| use Yiisoft\Db\Schema\Schema; | ||
|
|
||
| interface ConnectionInterface |
Member
There was a problem hiding this comment.
Should it contain more methods such as the following?
- beginTransaction(), getTransaction()
- open(), close(), isActive()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.