Skip to content

Improve column schema classes#899

Merged
Tigrov merged 5 commits intomasterfrom
improve-column-schema
Nov 16, 2024
Merged

Improve column schema classes#899
Tigrov merged 5 commits intomasterfrom
improve-column-schema

Conversation

@Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 15, 2024

  • Improve psalm annotations;
  • add ColumnSchemaInterface::null() method as alias to ColumnSchemaInterface::notNull(false)
    to be compatible with ColumnInterface;
  • add ColumnSchemaInterface::hasDefaultValue() method to check if default value is initialized, even if it is null value.

Related PRs

Q A
Is bugfix?
New feature? ✔️/❌
Breaks BC?
Fixed issues #854

@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (86fc92e) to head (aa7e304).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #899   +/-   ##
=========================================
  Coverage     99.60%   99.60%           
- Complexity     1538     1540    +2     
=========================================
  Files            81       81           
  Lines          3789     3801   +12     
=========================================
+ Hits           3774     3786   +12     
  Misses           15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 49647d9 into master Nov 16, 2024
@Tigrov Tigrov deleted the improve-column-schema branch November 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants