Skip to content

Remove requireTransaction() and $isolationLevel from AbstractCommand#999

Merged
vjik merged 3 commits intomasterfrom
782-remove-require-transaction
Jul 13, 2025
Merged

Remove requireTransaction() and $isolationLevel from AbstractCommand#999
vjik merged 3 commits intomasterfrom
782-remove-require-transaction

Conversation

@vjik
Copy link
Member

@vjik vjik commented Jul 13, 2025

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fix #782

Related PRs:

@codecov
Copy link

codecov bot commented Jul 13, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.00%. Comparing base (0d41aa8) to head (1f51f11).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Driver/Pdo/AbstractPdoCommand.php 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #999      +/-   ##
============================================
+ Coverage     98.91%   99.00%   +0.09%     
+ Complexity     1677     1673       -4     
============================================
  Files           102      102              
  Lines          4240     4228      -12     
============================================
- Hits           4194     4186       -8     
+ Misses           46       42       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team July 13, 2025 10:01
@vjik vjik added the status:code review The pull request needs review. label Jul 13, 2025
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
@vjik vjik merged commit 87b29b1 into master Jul 13, 2025
67 of 68 checks passed
@vjik vjik deleted the 782-remove-require-transaction branch July 13, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No usage of AbstractCommand::requireTransaction()

3 participants